feat: enable excluding refs search results in test #16441
Conversation
rustbot
added
the
S-waiting-on-review
|
I look a bit more about the latency in rust-analyzer server LSP log trace, compared the
|
|
@bors r+ |
|
☀️ Test successful - checks-actions |
| @@ -1055,6 +1055,7 @@ pub(crate) fn handle_references( | |||
| let position = from_proto::file_position(&snap, params.text_document_position)?; | |||
|
|
|||
| let exclude_imports = snap.config.find_all_refs_exclude_imports(); | |||
| let exclude_tests = snap.config.find_all_refs_exclude_tests(); | |||
There was a problem hiding this comment.
exclude_tests should be pushed down as a parameter to find_all_refs.
that way, a potentially more optimal implementation would be able to avoid even analyzing the test, which would be faster than filtering out results after the fact.
I think the second parameter we are passing here, which is currently None, is something like a SearchScope. It exists exactly to narrow down search results, and I think could be extended to exclude tests.
There was a problem hiding this comment.
good point, I had create an issue for this
(sorry for the slow response, kind of busy recently)
| @@ -134,6 +134,7 @@ pub enum ReferenceCategory { | |||
| // FIXME: Some day should be able to search in doc comments. Would probably | |||
| // need to switch from enum to bitflags then? | |||
| // DocComment | |||
| Test, | |||
There was a problem hiding this comment.
Something can be a test and a read at the same time. So, the time has come to use a bitset here! This is precisely the situation the old comment just above this line talks about
Change
Here I introduce a new
ReferenceCategory::Testtype to indicate whether the function where this reference is located is marked as#[test], and expose an config item (rust-analyzer.references.excludeTests) to client.I also changed the signature of
ReferenceCategory::new, adding asema: &Semantics<'_, RootDatabase>param to do some hir analysis. Hope the current implementation is good to go.Demo
"rust-analyzer.references.excludeTests": false"rust-analyzer.references.excludeTests": truePerformance
I look a bit more about the latency in rust-analyzer server LSP log trace, compared the
Find All Referencesbetween v0.4.1825 and this PR oversyntax::ast::AstNode::syntax()andide_assists::tests::check_assist(), taking an average of 5 operations response time (every operation is perform after restart rust-analyzer server so it's not the cache reslut). I found this PR does't bring noticable regression.close #14530