Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Lint debug prints and disallowed types with clippy #16470

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 1, 2024

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2024
enum CargoMessage {
CompilerArtifact(Box<cargo_metadata::Artifact>),
CompilerArtifact(cargo_metadata::Artifact),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha

@Veykril
Copy link
Member Author

Veykril commented Feb 1, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 1, 2024

📌 Commit 9570522 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 1, 2024

⌛ Testing commit 9570522 with merge 032e731...

bors added a commit that referenced this pull request Feb 1, 2024
Lint debug prints and disallowed types with clippy
@bors
Copy link
Collaborator

bors commented Feb 1, 2024

💔 Test failed - checks-actions

@lnicola lnicola changed the title Lint debug prints and disallowed types with clippy internal: Lint debug prints and disallowed types with clippy Feb 5, 2024
@lnicola
Copy link
Member

lnicola commented Feb 5, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 5, 2024

📌 Commit 9e8a0fa has been approved by lnicola

It is now in the queue for this repository.

@lnicola
Copy link
Member

lnicola commented Feb 5, 2024

@Veykril did you want to keep this open?

@bors
Copy link
Collaborator

bors commented Feb 5, 2024

⌛ Testing commit 9e8a0fa with merge 66cec4d...

@bors
Copy link
Collaborator

bors commented Feb 5, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 66cec4d to master...

@bors bors merged commit 66cec4d into rust-lang:master Feb 5, 2024
10 checks passed
@Veykril
Copy link
Member Author

Veykril commented Feb 5, 2024

No I just forgot to r+ it after fixing the last failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants