Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only complete traits in impl .. for #16544

Merged
merged 4 commits into from Feb 13, 2024
Merged

fix: only complete traits in impl .. for #16544

merged 4 commits into from Feb 13, 2024

Conversation

dfireBird
Copy link
Contributor

@dfireBird dfireBird commented Feb 12, 2024 •
edited

This is prerequisite PR for adding the assist mentioned in #12500

P.S: If wanted, I will add the implementation of the assist in this PR as well.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2024
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2024
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2024
Veykril
Veykril reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor simplifications

crates/ide-completion/src/completions/flyimport.rs Outdated Show resolved Hide resolved
crates/ide-completion/src/completions/type.rs Show resolved Hide resolved
@Veykril
Copy link
Member

Veykril commented Feb 13, 2024 •
edited

Thanks!
@bors delegate+

@bors
Copy link
Collaborator

bors commented Feb 13, 2024

✌️ @dfireBird, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

@Veykril
Copy link
Member

Veykril commented Feb 13, 2024

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Feb 13, 2024

📌 Commit 7f66178 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 13, 2024

⌛ Testing commit 7f66178 with merge fc1ee61...

@bors
Copy link
Collaborator

bors commented Feb 13, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing fc1ee61 to master...

@bors bors merged commit fc1ee61 into rust-lang:master Feb 13, 2024
11 checks passed
@dfireBird dfireBird mentioned this pull request Feb 13, 2024
Closed
@dfireBird dfireBird deleted the impl_trait_completion branch February 13, 2024 17:02
@lnicola lnicola changed the title Add completions to show only traits in trait impl statement fix: only complete traits in impl .. for Feb 13, 2024
This was referenced May 9, 2024
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dfireBird @Veykril @bors @rustbot