fix: Don't add \ before {
#16618
Merged
fix: Don't add \ before {
#16618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
DropDemBits
force-pushed
the
structured-snippet-fix-escape-left-curly
branch
from
7c5758d
to
825fd70
Compare
|
Thanks! |
bors
added a commit
that referenced
this pull request
Feb 20, 2024
…-curly, r=Veykril
fix: Don't add `\` before `{`
Fixes #16607 for `{`. The `}` case is already fixed by #16475.
The [LSP snippet grammar](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#snippet_syntax) only specifies that `$`, `}`, and `\` can be escaped with backslashes, but not `{`.
The LSP snippet grammar only specifies that `$`, `}`, and `\` can be escaped with
backslashes, but not `{`.
DropDemBits
force-pushed
the
structured-snippet-fix-escape-left-curly
branch
from
825fd70
to
07421c1
Compare
|
Whoops, forgot to actually commit & push the formatting changes 😅 |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced Feb 21, 2024
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16607 for
{. The}case is already fixed by #16475.The LSP snippet grammar only specifies that
$,}, and\can be escaped with backslashes, but not{.