internal: Implement parent-child relation for SourceRoots
#16742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
alibektas
force-pushed
the
13529/source_root_tree
branch
from
1eabeb4
to
349a0b6
Compare
alibektas
commented
Mar 3, 2024
alibektas
commented
Mar 3, 2024
alibektas
commented
Mar 3, 2024
alibektas
force-pushed
the
13529/source_root_tree
branch
2 times, most recently
from
ccf7081
to
cbe938b
Compare
alibektas
changed the title
SourceRootsSourceRoots
|
☔ The latest upstream changes (presumably #16747) made this pull request unmergeable. Please resolve the merge conflicts. |
Veykril
reviewed
Mar 4, 2024
davidbarsky
reviewed
Mar 4, 2024
alibektas
force-pushed
the
13529/source_root_tree
branch
3 times, most recently
from
1300cf1
to
5860374
Compare
Veykril
reviewed
Mar 5, 2024
Veykril
added
S-waiting-on-author
This commit adds the said relation by keeping a map of type `FxHashMap<SourceRootId,Option<SourceRootId>>` inside the `GlobalState`. Its primary use case is reading the rust-analyzer.toml files that can be placed under every local source root. As a config will be found by traversing this "tree" we need the parent information for every local source root. This commit omits defining this relation for library source roots entirely.
alibektas
force-pushed
the
13529/source_root_tree
branch
from
5860374
to
9c50d12
Compare
alibektas
added
S-waiting-on-review
Veykril
reviewed
Mar 7, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 12, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the said relation by keeping a map of type
FxHashMap<SourceRootId,Option<SourceRootId>>inside theGlobalState. Its primary use case is readingrust-analyzer.toml(#13529) files that can be placed in every local source root. As a config will be found by traversing this "tree" we need the parent information for every local source root. This commit omits defining this relation for library source roots entirely.