Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Put style lints behind disabled-by-default config #16757

Merged
merged 1 commit into from Mar 5, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 5, 2024

Fixes #16542
Fixes #16725
cc #16628

Our diagnostic infra is not yet setup for those kinds of diagnostics

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2024
@Veykril
Copy link
Member Author

Veykril commented Mar 5, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 5, 2024

📌 Commit 8844640 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 5, 2024

⌛ Testing commit 8844640 with merge 676455f...

@bors
Copy link
Collaborator

bors commented Mar 5, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 676455f to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 5, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 676455f to master...

@bors bors merged commit 676455f into rust-lang:master Mar 5, 2024
11 checks passed
@bors
Copy link
Collaborator

bors commented Mar 5, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nightly throws needless_return warning on anyhow::bail! Disable code Action for clippy::needless_return
3 participants