Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unncessary check for macro call #16787

Merged
merged 1 commit into from Mar 8, 2024

Conversation

pksunkara
Copy link
Contributor

Since macro_rules is a contextual keyword, it is an IDENT token and thus is_path_start already identifies it correctly. You can tell the previous check is unnecessary because the relevant tests still pass.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 8, 2024
@lnicola
Copy link
Member

lnicola commented Mar 8, 2024

Yeah, I'm not sure what this is trying to do, but it looks like a no-op today.

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 8, 2024

📌 Commit a838e44 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 8, 2024

⌛ Testing commit a838e44 with merge 2397e7a...

@pksunkara
Copy link
Contributor Author

@lnicola Can I please get pinged on PRs to change parser crate? I can start helping in reviewing them.

@bors
Copy link
Collaborator

bors commented Mar 8, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 2397e7a to master...

@bors bors merged commit 2397e7a into rust-lang:master Mar 8, 2024
11 checks passed
@pksunkara pksunkara deleted the remove-macro-call-check branch March 8, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants