Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't auto-close block comments in strings #16820

Merged
merged 1 commit into from Mar 12, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Mar 12, 2024

Fixes #16815

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2024
@lnicola
Copy link
Member Author

lnicola commented Mar 12, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 12, 2024

📌 Commit cb6c26b has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 12, 2024

⌛ Testing commit cb6c26b with merge 9bc1eb4...

@bors
Copy link
Collaborator

bors commented Mar 12, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 9bc1eb4 to master...

@bors bors merged commit 9bc1eb4 into rust-lang:master Mar 12, 2024
11 checks passed
@lnicola lnicola deleted the no-string-comment-autoclose branch March 13, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect insertion of a comment in a string in VSCode
3 participants