Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle attributes when typing curly bracket #16868

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

roife
Copy link
Member

@roife roife commented Mar 18, 2024

fix #16848.

When inserting a {, if it is identified that the front part of expr is attr, we consider it as inserting {} around the entire expr (excluding the attr part).

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2024
@Veykril
Copy link
Member

Veykril commented Mar 18, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 18, 2024

📌 Commit 109344c has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 18, 2024

⌛ Testing commit 109344c with merge f07489a...

@bors
Copy link
Collaborator

bors commented Mar 18, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f07489a to master...

@bors bors merged commit f07489a into rust-lang:master Mar 18, 2024
11 checks passed
@roife roife deleted the fix-issue-16848 branch April 1, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"editor.formatOnType": true (vscode) behaves weirdly with calls (and attributes on calls)
4 participants