Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use lldb when debugging with C++ extension on MacOS #16965

Merged
merged 1 commit into from Mar 28, 2024

Conversation

roife
Copy link
Contributor

@roife roife commented Mar 28, 2024

See #16901 (comment)

This PR resolves the issue of being unable to debug using the C++ extension on macOS. By using special configurations for the MIMode on macOS, it enables the C++ extension to connect to lldb when debugging (without affecting other platforms).

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2024
@roife
Copy link
Contributor Author

roife commented Mar 28, 2024

cc @lnicola. I believe this PR resolves the issue of debugging with the C++ extension.

@lnicola
Copy link
Member

lnicola commented Mar 28, 2024

I take it this works without also setting miDebuggerPath?

@lnicola lnicola changed the title fix: use lldb when debugging with C++ extension fix: use lldb when debugging with C++ extension on MacOS Mar 28, 2024
@lnicola
Copy link
Member

lnicola commented Mar 28, 2024

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Mar 28, 2024

📌 Commit 3521089 has been approved by lnicola

It is now in the queue for this repository.

@roife
Copy link
Contributor Author

roife commented Mar 28, 2024

By setting MIMode, VScode will automatically use lldb in the PATH.

@bors
Copy link
Collaborator

bors commented Mar 28, 2024

⌛ Testing commit 3521089 with merge 29a8e65...

@bors
Copy link
Collaborator

bors commented Mar 28, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 29a8e65 to master...

@bors bors merged commit 29a8e65 into rust-lang:master Mar 28, 2024
11 checks passed
@roife roife deleted the use-lldb-for-cpp-ext branch March 28, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants