fix: ADT hover considering only type or const len not lifetimes #16967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
reviewed
Mar 28, 2024
|
My bad, amended without changes accidentally. |
lnicola
approved these changes
Mar 28, 2024
|
Thanks! @bors r+ |
|
The test does its job (crash without the fix), it's fine. |
|
☀️ Test successful - checks-actions |
Veykril
reviewed
Mar 28, 2024
| @@ -1418,7 +1418,8 @@ impl Adt { | |||
| } | |||
|
|
|||
| pub fn layout(self, db: &dyn HirDatabase) -> Result<Layout, LayoutError> { | |||
| if db.generic_params(self.into()).iter().count() != 0 { | |||
| let generic_params = &db.generic_params(self.into()); | |||
| if generic_params.iter().next().is_some() || generic_params.iter_lt().next().is_some() { | |||
There was a problem hiding this comment.
Having a GenericParam::is_empty method would probably be useful here (or given there is more than just params in it, a GenericParam::has_params)
There was a problem hiding this comment.
Should I open a PR with the proposed change of this and the proposed change in another PR?
Feel like a opening a lot of small PRs 😅.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like test doesn't do much. Please suggest if I should improve it?
Fixes #16963