Try to generate more meaningful names in json converter

[leviska]

I just found out about rust-analyzer json converter, but I think it would be more convenient, if names were more useful, like using the names of the keys.

Let's look at some realistic arbitrary json:

{
    "user": {
        "address": {
            "street": "Main St",
            "house": 3
        },
        "email": "example@example.com"
    }
}

I think, new generated code is much easier to read and to edit, than the old:

// Old
struct Struct1{ house: i64, street: String }
struct Struct2{ address: Struct1, email: String }
struct Struct3{ user: Struct2 }

// New
struct Address1{ house: i64, street: String }
struct User1{ address: Address1, email: String }
struct Root1{ user: User1 }

Ideally, if we drop the numbers, I can see it being usable just as is (may be rename root)

struct Address{ house: i64, street: String }
struct User{ address: Address, email: String }
struct Root{ user: User }

Sadly, we can't just drop them, because there can be multiple fields (recursive) with the same name, and we can't just easily retroactively add numbers if the name has 2 instances due to parsing being single pass.
We could ignore the 1 and add number only if it's > 1, but I will leave this open to discussion and right now made it the simpler way

In sum, even with numbers, I think this PR still helps in readability

[leviska]

I don't want to copy if name exists, so this long if

[leviska]

I just remembered, that the name in json can be invalid struct name... I'll try to find a way to check that I guess

[leviska]

Actually, the old code fails at this too, because it doesn't fix the names for struct member variables...

[Veykril]

Thanks!
@bors r+

[bors]

📌 Commit 029c710 has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit 029c710 with merge 3077e69...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 3077e69 to master...