minor: let diagnostics.enable's scope be limited to DiagnosticsCode::Ra only #17146
+92
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
alibektas
changed the title
Veykril
reviewed
Apr 29, 2024
There was a problem hiding this comment.
The code in question here seems correct to me, in that these parts configure the native diagnostics only (opposed to flycheck ones). Us mapping some of r-a's diagnostics to rustc error codes is irrelevant to the setting in my eyes. I'd say the point of the setting is to just not get real time diagnostics which is what it currently configures.
Veykril
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the config
rust-analyzer.diagnostics.enablestates : "Whether to show native rust-analyzer diagnostics". However as I further investigated #17048 I came to the conclusion that the thing it currently does is to disable/enable diagnostics completely. I am not sure if that's the desired behavior. If so, this PR should better be closed.If not this PR changes the said config to regulate whether we should show diagnostics with diagnostics code
DiagnosticCode::Raor not and thereby fixes #17048.As to the new test : It only serves the purpose of demonstrating what the change means. As soon as it becomes clear that this PR has any sense I will write a test under ide_diagnostics