Fix Run lens showing when lenses are disabled #17177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for `lens.run.enable` states that it only applies when `lens.enable` is set. However, the config setting whether to show the Run lens did not check `lens.enable`, so the Run lens would show even though lenses were disabled.
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
May 3, 2024
|
Thanks! |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have disabled Rust Analyzer lenses in my VSCode settings, but noticed that the
Runlens still showed. This surprised me, as the docs forlens.run.enablestate that it only applies whenlens.enableis set. I then found that where we setLensConfig::run, we don't checklens_enablelike for the other settings. We did this previously, so this seems like a regression from refactoring. This PR tries to fix that.