fix: use ItemInNs::Macros to convert ModuleItem to ItemInNs

[roife]

fix #17425.

When converting PathResolution to ItemInNs, we should convert ModuleDef::Macro to ItemInNs::Macros to ensure that it can be found in DefMap.

[roife]

I'm not sure whether it's correct since I am not very familiar with Ns.

What's the difference between ItemInNs::Types(ModuleDef::Macro) and ItemInNs::Macros?👀

[Veykril]

ItemInNs carries the namespace this resolution is coming from/supposed to be treated as being in. So ItemInNs::Types(ModuleDef::Macro) means a Macro in a type namespace context which is technically non-sensical, as macros can only exist in the macro namespace. The reason for this ItemInNs system is that some things can be in different namespaces, a unit struct for example can be in the type namespace given its a type but also in the value namespace as it can refer to its unit constructor.

[roife]

Thanks, I get it. Then this PR should be OK.

[Veykril]

@bors r+

[bors]

📌 Commit d5bb2f0 has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit d5bb2f0 with merge c4681ea...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing c4681ea to master...