Add --keep-going to the check command

[mo8it]

Fixes rust-lang/rustlings#1628

@Veykril I am not sure about what you meant with "unconditionally" in rust-lang/rustlings#1628 (comment), but I didn't find out how to get the version of the toolchain anyway to do a check like in this snippet. Is this check even required if rust-analyzer was installed with the toolchain?

--keep-going was stabilized in 1.74

[Veykril]

The check isn't require as we don't support toolchains that old anyways (it is impossible to reliably support a big range of rust versions)
Thanks!
@bors r+

[bors]

📌 Commit 9d01d7c has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9d01d7c with merge 8f841ca...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 8f841ca to master...

[mo8it]

@Veykril Should I remove the check here then?

[lnicola]

Yeah, we can probably drop it, it's been a while.

[huntc]

The check isn't require as we don't support toolchains that old anyways (it is impossible to reliably support a big range of rust versions) Thanks! @bors r+

This has caused a problem with a couple of my projects that are pinned to 1.72 of Rust. Is there a way we can make this conditional e.g. don't include the check if the compiler is pre-1.74?

Please see #17662.

I also understand that there's no strict backward-compability statement for RA, but Zed and VSC don't appear to honour rust-toolchain rust-analyzer components, so we're a bit stuck. Also see zed-industries/zed#4883 (comment)

[devanlai]

The check isn't require as we don't support toolchains that old anyways (it is impossible to reliably support a big range of rust versions) Thanks! @bors r+

This has caused a problem with a couple of my projects that are pinned to 1.72 of Rust. Is there a way we can make this conditional e.g. don't include the check if the compiler is pre-1.74?

Please see #17662.

I also understand that there's no strict backward-compability statement for RA, but Zed and VSC don't appear to honour rust-toolchain rust-analyzer components, so we're a bit stuck. Also see zed-industries/zed#4883 (comment)

I ran into the same issue with being pinned to an older rust version. For VSCode at least, I've found that using rust-analyzer's config to use the stable toolchain instead seems to work fine, presuming that for analysis purposes, the stable toolchain is fine.

[Veykril]

but Zed and VSC don't appear to honour rust-toolchain rust-analyzer components, so we're a bit stuck.

That is a good point to raise, we should be able to support the toolchain component in an overwrite if its installed imo. Though that is the job of the client as that is the entity responsible for spawning the process. We can do this in VSCode but Zed would need to do that themselves.

[Veykril]

I'll try to look into the VSCode thing here #17663, zed can then probably try to do something similar