Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emacs fixes #2963

Merged
merged 2 commits into from Feb 1, 2020
Merged

Emacs fixes #2963

merged 2 commits into from Feb 1, 2020

Conversation

flodiebold
Copy link
Member

  • use provided environment for runnables (finally set RUST_BACKTRACE)
  • implement selectAndApplySourceChange so auto-import works 🙂

cc @brotzeit

@brotzeit
Copy link
Contributor

Wow auto-import, nice!

@matklad
Copy link
Member

matklad commented Feb 1, 2020

bors r+

bors bot added a commit that referenced this pull request Feb 1, 2020
2963: Emacs fixes r=matklad a=flodiebold

 - use provided environment for runnables (finally set `RUST_BACKTRACE`)
 - implement `selectAndApplySourceChange` so auto-import works 🙂 

cc @brotzeit 

2967: Disable optimizations for some build-time crates r=matklad a=lnicola

This speeds up a release build on my laptop from 4m 13s to 3m 33s. It's a bit disappointing, but we don't get perfect parallelism during the build. The non-RA dependencies finish building around 72s as opposed to 112s.

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Co-authored-by: Florian Diebold <florian.diebold@freiheit.com>
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
@bors
Copy link
Contributor

bors bot commented Feb 1, 2020

Build succeeded

  • Rust (macos-latest)
  • Rust (ubuntu-latest)
  • Rust (windows-latest)
  • TypeScript

@bors bors bot merged commit 2586cf9 into rust-lang:master Feb 1, 2020
@flodiebold flodiebold deleted the emacs-fixes branch December 9, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants