Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rand with oorandom #5574

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Replace rand with oorandom #5574

merged 2 commits into from
Jul 29, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 29, 2020

bors r+
🤖

bors bot added a commit that referenced this pull request Jul 29, 2020
@bors @matklad
Merge #5574
7261be1 
5574: Replace rand with oorandom r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@matklad @lnicola
Update crates/rust-analyzer/src/cli/analysis_stats.rs
63de7bb 
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 29, 2020

Canceled.

@matklad
Copy link
Member Author

matklad commented Jul 29, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 29, 2020

Build succeeded:

@bors bors bot merged commit 2e10f15 into rust-lang:master Jul 29, 2020
@jens1o
Copy link
Contributor

jens1o commented Aug 8, 2020

What is the advantage of this crate over the more established rand crate?

@lnicola
Copy link
Member

lnicola commented Aug 8, 2020

Fewer dependencies, and it's only used for minor features, so it doesn't matter too much.

@matklad
Copy link
Member Author

matklad commented Aug 8, 2020 via email

@marioortizmanero marioortizmanero mentioned this pull request Aug 12, 2020
Closed
@matklad matklad deleted the unrand branch August 13, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matklad @jens1o @lnicola