Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show progress for fetching workspace (cargo-metadata and loadOutDirsFromCheck) #7193

Merged
merged 2 commits into from Jan 7, 2021
Merged

Show progress for fetching workspace (cargo-metadata and loadOutDirsFromCheck) #7193

merged 2 commits into from Jan 7, 2021

Conversation

edwin0cheng
Copy link
Member

Peek 2021-01-07 21-57

Fixes #7188
Fixes #3300

@edwin0cheng edwin0cheng changed the title Show progress when fetching workspace (cargo-metadata and loadOutDirsFromCheck) Show progress for fetching workspace (cargo-metadata and loadOutDirsFromCheck) Jan 7, 2021
matklad
matklad reviewed Jan 7, 2021
View reviewed changes
crates/stdx/src/lib.rs Outdated Show resolved Hide resolved
crates/project_model/src/cargo_workspace.rs Outdated Show resolved Hide resolved
crates/project_model/src/workspace.rs Outdated Show resolved Hide resolved
crates/project_model/src/workspace.rs Outdated Show resolved Hide resolved
@edwin0cheng
Copy link
Member Author

Fixed !

@matklad
Copy link
Member

matklad commented Jan 7, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 7, 2021

Canceled.

@edwin0cheng
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Jan 7, 2021
@bors @edwin0cheng
Merge #7191 #7193
2c32e59 
7191: Adjust vfs crate documentation r=matklad a=arnaudgolfouse

This removes an outdated comment, and uses intra-doc links

7193: Show progress for fetching workspace (cargo-metadata and loadOutDirsFromCheck) r=matklad a=edwin0cheng


![Peek 2021-01-07 21-57](https://user-images.githubusercontent.com/11014119/103902132-0db4c780-5135-11eb-94d3-32429445be87.gif)


Fixes #7188 
Fixes #3300

Co-authored-by: Arnaud <arnaud.golfouse@free.fr>
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 7, 2021

This PR was included in a batch that timed out, it will be automatically retried

@bors
Copy link
Contributor

bors bot commented Jan 7, 2021

Build succeeded:

@bors bors bot merged commit 4ddf075 into rust-lang:master Jan 7, 2021
@edwin0cheng edwin0cheng deleted the report-metadata branch January 7, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@edwin0cheng @matklad