Implement "Extract type alias" assist #8210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one snippet per TextEdit, multiple in the same TextEdit are still broken
matklad
reviewed
Mar 29, 2021
Comment on lines
61
to
66
| builder.replace_snippet(cap, target, "${0:Type}"); | ||
| builder.insert_snippet( | ||
| cap, | ||
| insert, | ||
| format!("type ${{0:Type}} = {};\n\n", node), | ||
| ); |
There was a problem hiding this comment.
🤔
Three separate thoughts:
- the snippet's
${0}feels like a wrong tool here: it can't express the fact that the second position should be focused (primary). - Our "extract variable" works differently as well, it just foceses the new name (so that it's possible to rename it later)
- I've noticed that type-script applies rename automatically. I think they just set the
commandto rename?
So, let's implement the same logic as extract variable now, and then add something like
/**
* A command this code action executes. If a code action
* provides an edit and a command, first the edit is
* executed and then the command.
*/
command?: Command;There was a problem hiding this comment.
Oh, I see, that does seem better!
There was a problem hiding this comment.
I'll implement this part later
|
bors r+ |
|
changelog feature |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.