minor: Update npm deps

[lnicola]

No description provided.

[lnicola]

r? @matklad

I didn't update @rollup/plugin-commonjs all the way because of a strange error:

The language client requires VS Code version ^1.53.0 but received version 1.56.2.

We might as well switch to esbuild, which seems to be the most liked bundler these days /s.

[matklad]

So what exactly are we pulling in from out?

[bjorn3]

The out/src dir. By the way !out/src/main.js is not necessary if you have !out/src but not out/src/**.

[lnicola]

Status: this is marked as a draft because it breaks loading the extension. I didn't notice it because there's no error thrown.

[lnicola]

r? @matklad

[matklad]

Scheduled for r+ on Monday!

[matklad]

bors r+

[bors]

Build succeeded:

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (ubuntu-latest)
• TypeScript (windows-latest)

[yaymukund]

I didn't update @rollup/plugin-commonjs all the way because of a strange error:

The language client requires VS Code version ^1.53.0 but received version 1.56.2.

We might as well switch to esbuild, which seems to be the most liked bundler these days /s.

Very mysterious bug.

It's worth noting that this blocks updating rollup itself. If you update to rollup@2.55 without @rollup/plugin-commonjs@19, you run into rollup/rollup#4195 . I encountered this while trying to package this extension for Nix.

Sorry to ping you on this old issue, I just thought it might save you some debugging in the future because it was fairly tricky to chase down.

[lnicola]

Thanks for the ping, though I'll probably forget by then.

---

Anyway, as a non-web developer, the whole JS bundler ecosystem seems Kafkaesque.

[matklad]

One morning, as Gregor Samsa was waking up from anxious dreams, he discovered that his bed had been moved into node_modules.

[matklad]

Curiously, the docs now put esbuild to the first place:

https://code.visualstudio.com/api/working-with-extensions/bundling-extension#using-esbuild

I wonder if we should switch to that? On the one hand, I wouldn't want to pull yet another ecosystem (esbuild is in go), on the other hand, the pain with rollup/webpack is real, and the example in the docs does seem nice.

Fun fact: esbuild could have been written in Rust, but there was this blockin issue.

[yaymukund]

One morning, as Gregor Samsa was waking up from anxious dreams, he discovered that his bed had been moved into node_modules.

horror! 😂

I can try to integrate esbuild in the coming week, if this is something you feel is worth pursuing.

Also, that is a neat bit of trivia about esbuild. I wonder if swc has ever run into the same thing.

[lnicola]

I can try to integrate esbuild in the coming week, if this is something you feel is worth pursuing.

If it means less npm deps in package.json, yes!

npm i --save-dev esbuild

Oh.

[yaymukund]

If it means less npm deps in package.json, yes!

It would still reduce the number of dependencies because it has no dependencies of its own.

I wonder if we should switch to that? On the one hand, I wouldn't want to pull yet another ecosystem (esbuild is in go), on the other hand, the pain with rollup/webpack is real, and the example in the docs does seem nice.

For what it's worth, it wouldn't require Go as a build dependency. npm just pulls the static binary from the registry.