Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rust-logo-blk.svg adapt to color-scheme #13

Closed
wants to merge 2 commits into from
Closed

make rust-logo-blk.svg adapt to color-scheme #13

wants to merge 2 commits into from

Conversation

Rudxain
Copy link

@Rudxain Rudxain commented Dec 4, 2022

This makes it easier to see in dark backgrounds

@Rudxain
Copy link
Author

Rudxain commented Dec 4, 2022

For some reason, Chrome for Android renders it without the gear, but Firefox renders it identical to the original... does anyone know why? I've read that prefers-color-scheme in SVGs is supported in Chrome for desktop, so this makes no sense to me

Update: nevermind, I "fixed it" in this commit

@Rudxain
Copy link
Author

Rudxain commented Dec 5, 2022

For some reason #cir never shows up in Firefox dark theme, regardless of fill color (I tried none, white, and black), and regardless of background color... I gave up

@Rudxain
Copy link
Author

Rudxain commented Dec 5, 2022

Some SVG renderers don't even detect the system color-scheme, so this is basically useless

@Rudxain Rudxain closed this Dec 5, 2022
@Rudxain Rudxain deleted the patch-1 branch December 5, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant