Skip to content

Commit

Permalink
tests: Minor simplification of test harness.
Browse files Browse the repository at this point in the history
We were never returning Ok(None), so not sure why this was ever there.
  • Loading branch information
emilio committed Jul 1, 2020
1 parent eab1137 commit 51ff49a
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions tests/tests.rs
Expand Up @@ -247,7 +247,7 @@ fn builder() -> Builder {
bindgen::builder().disable_header_comment()
}

fn create_bindgen_builder(header: &PathBuf) -> Result<Option<Builder>, Error> {
fn create_bindgen_builder(header: &PathBuf) -> Result<Builder, Error> {
#[cfg(feature = "logging")]
let _ = env_logger::try_init();

Expand Down Expand Up @@ -319,7 +319,7 @@ fn create_bindgen_builder(header: &PathBuf) -> Result<Option<Builder>, Error> {
.map(ToString::to_string)
.chain(flags.into_iter());

builder_from_flags(args).map(|(builder, _, _)| Some(builder))
builder_from_flags(args).map(|(builder, _, _)| builder)
}

macro_rules! test_header {
Expand All @@ -328,11 +328,7 @@ macro_rules! test_header {
fn $function() {
let header = PathBuf::from($header);
let result = create_bindgen_builder(&header).and_then(|builder| {
if let Some(builder) = builder {
compare_generated_header(&header, builder)
} else {
Ok(())
}
compare_generated_header(&header, builder)
});

if let Err(err) = result {
Expand Down

0 comments on commit 51ff49a

Please sign in to comment.