Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a member names callback for ParseCallbacks #1796

Closed
wants to merge 3 commits into from
Closed

Add a member names callback for ParseCallbacks #1796

wants to merge 3 commits into from

Conversation

chayleaf
Copy link

@chayleaf chayleaf commented Jun 6, 2020

I'm new to both rust and bindgen, so please tell me if there's something I'm doing wrong here, but at least it works

@chayleaf
Copy link
Author

chayleaf commented Jun 6, 2020

just found a bug in test generation, don't merge yet

@chayleaf chayleaf marked this pull request as draft June 6, 2020 13:26
@chayleaf
Copy link
Author

chayleaf commented Jun 6, 2020

hopefully should be good now

@chayleaf chayleaf marked this pull request as ready for review June 6, 2020 16:47
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on what the use case for this is?

Also, this would need some tests, see the bindgen-integration directory for examples.

@chayleaf
Copy link
Author

chayleaf commented Jun 7, 2020

Use case is similar to the item_name callback. I personally used it to snake case'ify every member function in the bindings. As of tests - there aren't any tests for ParseCallbacks in the first place, and I can't run the test suite as I'm using Windows.

@emilio
Copy link
Contributor

emilio commented Jun 7, 2020

There definitely are tests for parse callbacks:

impl ParseCallbacks for MacroCallback {

@kulp
Copy link
Member

kulp commented Jun 7, 2020

@pavlukivan, maybe my concurrent work in #1793 will be helpful to you ? I added some tests there (although I do not know if I did it well, since my code is still pending review).

@chayleaf
Copy link
Author

chayleaf commented Jun 8, 2020

I see, I couldn't find the test because it wasn't using expectations. I'll see what I can do.

@chayleaf chayleaf marked this pull request as draft June 8, 2020 16:22
@chayleaf
Copy link
Author

chayleaf commented Aug 2, 2020

i don't need this anymore so I will close this and let others do it if the need arises

@chayleaf chayleaf closed this Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants