Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindgen shouldn't generate f32 for c floats #1851

Open
jdm opened this issue Jul 29, 2020 · 3 comments
Open

bindgen shouldn't generate f32 for c floats #1851

jdm opened this issue Jul 29, 2020 · 3 comments
Labels

Comments

@jdm
Copy link
Contributor

jdm commented Jul 29, 2020

According to the conversation in gnzlbg/ctest#69 (comment), the fact that bindgen switched from generating c_float to f32 is a bug. I've encountered this in the harfbuzz bindings via https://github.com/servo/rust-harfbuzz/blob/d782b2c021978c615b870588555df80996dd39f7/harfbuzz-sys/harfbuzz/src/hb-font.h#L692.

@emilio
Copy link
Contributor

emilio commented Jul 31, 2020

@jdm curious, what platform are you on that has floats that aren't f32?

It's technically a bug, but not really something that I'd expect to come up with any sort of frequency.

@emilio
Copy link
Contributor

emilio commented Jul 31, 2020

What is the issue that you're hitting with harfbuzz? It's likely that's unrelated if you're in any sort of "common" platform.

@emilio emilio changed the title bindgen shouldn't generate f32 bindgen shouldn't generate f32 for c floats Jul 31, 2020
@emilio emilio added the bug label Jul 31, 2020
@jdm
Copy link
Contributor Author

jdm commented Jul 31, 2020

@emilio I'm only paraphrasing the comments that I linked to. In this case, the presence of f32 broke ctest, which seems disinclined to add support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants