Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ir: Don't eagerly-resolve template alias declarations. #1124

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Oct 30, 2017

Fixes #1118

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio
Copy link
Contributor Author

emilio commented Oct 30, 2017

r? @fitzgen or @pepyakin

@pepyakin
Copy link
Contributor

r=me, but I'm not yet feel confident in parsing clang ir

@emilio
Copy link
Contributor Author

emilio commented Oct 30, 2017

@bors-servo r=pepyakin

  • I think nobody is ;)

@bors-servo
Copy link

📌 Commit 0db2bd0 has been approved by pepyakin

@bors-servo
Copy link

⌛ Testing commit 0db2bd0 with merge 842ba8b...

bors-servo pushed a commit that referenced this pull request Oct 30, 2017
ir: Don't eagerly-resolve template alias declarations.

Fixes #1118
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: pepyakin
Pushing 842ba8b to master...

@bors-servo bors-servo merged commit 0db2bd0 into rust-lang:master Oct 30, 2017
@emilio emilio mentioned this pull request Oct 30, 2017
bors-servo pushed a commit that referenced this pull request Oct 30, 2017
Minor version bump.

Again, just fixes, and I got FF to build with #1124.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants