ir: We can't guarantee the type to be in the item map while propagating AlreadyResolved #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit 9601c1b has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 31, 2017
ir: We can't guarantee the type to be in the item map while propagating AlreadyResolved The item may come from a recursive check down the stack, and as we say there: > Unchecked because we haven't finished this type yet. Fixes #1127
|
💔 Test failed - status-travis |
|
@bors-servo retry
|
bors-servo
pushed a commit
that referenced
this pull request
Oct 31, 2017
ir: We can't guarantee the type to be in the item map while propagating AlreadyResolved The item may come from a recursive check down the stack, and as we say there: > Unchecked because we haven't finished this type yet. Fixes #1127
|
Oh, it looks like this testcase is timing out on llvm 4.0, fun... brb |
…ng AlreadyResolved. The item may come from a recursive check down the stack, and as we say there: > Unchecked because we haven't finished this type yet. Fixes rust-lang#1127
|
I'm punting on landing the test-case because I just verified this allows me to update bindgen in mozilla-central, but I plan to look at it (filed #1129). |
|
@bors-servo r=fitzgen |
|
📌 Commit 1554388 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 31, 2017
ir: We can't guarantee the type to be in the item map while propagating AlreadyResolved The item may come from a recursive check down the stack, and as we say there: > Unchecked because we haven't finished this type yet. Fixes #1127
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The item may come from a recursive check down the stack, and as we say there:
Fixes #1127