codegen: signed bitfield handling #2046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chenhengqi <chenhengqi@outlook.com>
emilio
requested changes
May 8, 2021
| #offset, | ||
| #width | ||
| ); | ||
| if (#is_signed) { |
There was a problem hiding this comment.
No braces, please.
Instead of having this branch in the generated code, we should instead change the generated code depending on whether the signed field is signed.
| @@ -1632,6 +1632,7 @@ impl<'a> FieldCodegen<'a> for Bitfield { | |||
| } | |||
| }; | |||
|
|
|||
| let is_signed = bitfield_ty.as_integer().unwrap().is_signed(); | |||
There was a problem hiding this comment.
C++ allows you to have enum bitfields, does that still work with this patch?
|
|
||
| #[inline] | ||
| pub fn signed_val(val: u64, bits: usize) -> i64 { | ||
| if bits == 64 { |
There was a problem hiding this comment.
Instead of having this here, let's have it as a static function in the type, to minimize the chances of naming conflicts (so put it inside the impl block, and call it like Self::signed_val(..) instead.
|
Thanks. Will get back to here when I resolve all the problems. |
|
☔ The latest upstream changes (presumably #2284) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1160
Now we have the correct behavior:
Signed-off-by: Hengqi Chen chenhengqi@outlook.com