Restore prettyplease feature gate to bindgen library crate #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this might be blocked on #2536 |
pvdrz
requested changes
May 29, 2023
|
@pvdrz this is ready for review and CI is green |
This is a partial revert of these two PRs: - #2491 - #2505 Allow formatting of generated bindings and the inclusion of the `prettyplease` dependency to be optional when depending on bindgen as a library. `prettyplease` remains required and enabled by bindgen-cli. In a project I maintain, `bindgen` is used in a build script to generate bindings for a native C library. Those bindings are written to `OUT_DIR` and are `include!`'d into the crate sources; these bindings don't need to be formatted. See for additional context: - #2491 (comment) - #2491 (comment) - #2491 (comment) I tested all of the following locally: ```shell cd bindgen cargo check cargo check --no-default-features cargo check --no-default-features --features prettyplease ``` The CI steps added in #2506 should be sufficient for maintaining the correctness of these conditional compilation features.
pvdrz
approved these changes
Jun 2, 2023
|
thanks! |
|
Curious @pvdrz, when is a release scheduled / can one be made? I got asked about this because we want to update to syn 2, but we'd rather avoid pulling in prettyplease. No rush tho. Thanks! |
|
Someone told me that we do releases when people ask for them I think we have enough features for a new release too so I guess later this week or maybe starting next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of these two PRs:
prettypleasenon-optional #2491Allow formatting of generated bindings and the inclusion of the
prettypleasedependency to be optional when depending on bindgen as a library.prettypleaseremains required and enabled by bindgen-cli.In a project I maintain,
bindgenis used in a build script to generate bindings for a native C library. Those bindings are written toOUT_DIRand areinclude!'d into the crate sources; these bindings don't need to be formatted.See for additional context:
prettypleasenon-optional #2491 (comment)prettypleasenon-optional #2491 (comment)prettypleasenon-optional #2491 (comment)I tested all of the following locally:
cd bindgen cargo check cargo check --no-default-features cargo check --no-default-features --features prettypleaseThe CI steps added in #2506 should be sufficient for maintaining the correctness of these conditional compilation features.
cc @pvdrz