Add target mappings for riscv32imc and riscv32imac #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdrz
approved these changes
Jun 10, 2023
TheConner
added a commit
to TheConner/rust-bindgen
that referenced
this pull request
Jun 10, 2023
Similar problem as the one mentioned in rust-lang#2136, just continuing by adding the 32 bit risc tuple mappings. Tuples like riscv32imc- and riscv32imac- should map to the clang riscv32- tuple. Fixed by adding mappings and tests for the mappings. Projects that now failed to build the "riscv32imac-unknown-none-elf" target tuple now build without issue.
|
Added to changelog. Also, I agree there should be some form of integration tests that aims to test all of the target tuple edge cases, perhaps seeing if a basic example can be compiled without clang throwing an error if the mapped target tuple doesn't exist. |
pvdrz
approved these changes
Jun 10, 2023
nspin
added a commit
to nspin/rust-bindgen
that referenced
this pull request
Feb 7, 2024
Similar change to rust-lang#2551. Just filling in more mappings.
emilio
pushed a commit
that referenced
this pull request
Feb 7, 2024
Similar change to #2551. Just filling in more mappings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar problem as the one mentioned in #2136, just continuing by adding the 32 bit risc tuple mappings. Tuples like riscv32imc- and riscv32imac- should map to the clang riscv32- tuple.
Fixed by adding mappings and tests for the mappings. Projects that now failed to build with the "riscv32imac-unknown-none-elf" target tuple now build without issue.