Compile time layout tests #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
kulp
reviewed
Mar 25, 2024
|
This looks great, though I think it's a requirement to make it the default to be able to tell how the values differ... Can we use |
|
(or does the assert macro print that already?) |
|
There's no way to print such thing on |
|
I haven't been able to play with this yet but maybe we can abuse slice indexing to at least print the differences between actual and expected? E.g for |
|
oh that's so hacky... I love it! |
|
Using slice indexing works. I've put the string as the expression in the array rather than |
GKFX
force-pushed
the
compile-time-layout-tests
branch
from
cbb817f
to
d508b91
Compare
emilio
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit emits layout tests as compile-time assertions, rather than as unit tests. This allows them to be run in situations where running unit tests is unfeasible, i.e. cross-compiled code and nostd targets.
Fixes #2786. @ojeda - I noticed you tagged the feature request for Rust-for-Linux.