Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace constructors #448

Merged
merged 2 commits into from Jan 27, 2017
Merged

Trace constructors #448

merged 2 commits into from Jan 27, 2017

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 27, 2017

r? @emilio

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Sorry for not looking at whether we tracked them separately or not before, got sidetracked :)

@@ -978,5 +978,9 @@ impl TypeCollector for CompInfo {
for method in self.methods() {
types.insert(method.signature);
}

for &ctor in self.constructors() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, so we did track them separately :)

@emilio
Copy link
Contributor

emilio commented Jan 27, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit e9e561b has been approved by emilio

@fitzgen
Copy link
Member Author

fitzgen commented Jan 27, 2017

Hrm.... looks like we have a lot of unresolved type refs... Not sure why this didn't trigger locally :-/

---- header_typeref_hpp stdout ----

	thread 'header_typeref_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_union_dtor_hpp stdout ----

	thread 'header_union_dtor_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_union_template_hpp stdout ----

	thread 'header_union_template_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_template_hpp stdout ----

	thread 'header_template_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_vector_hpp stdout ----

	thread 'header_vector_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_union_with_big_member_h stdout ----

	thread 'header_union_with_big_member_h' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_using_hpp stdout ----

	thread 'header_using_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_variadic_method_hpp stdout ----

	thread 'header_variadic_method_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_whitelist_basic_hpp stdout ----

	thread 'header_whitelist_basic_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_use_core_h stdout ----

	thread 'header_use_core_h' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_what_is_going_on_hpp stdout ----

	thread 'header_what_is_going_on_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_whitelist_fix_hpp stdout ----

	thread 'header_whitelist_fix_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

---- header_vtable_recursive_sig_hpp stdout ----

	thread 'header_vtable_recursive_sig_hpp' panicked at 'internal error: entered unreachable code', src/ir/ty.rs:925

This is a useful debugging tool for us to catch when code generation and
whitelisting have different understandings of the world.
@bors-servo
Copy link

⌛ Testing commit e9e561b with merge 2f627b9...

@fitzgen
Copy link
Member Author

fitzgen commented Jan 27, 2017

Trying without that commit.

@bors-servo r=emilio

@bors-servo
Copy link

📌 Commit 44ed608 has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 44ed608 with merge 7bfb5a5...

bors-servo pushed a commit that referenced this pull request Jan 27, 2017
@emilio
Copy link
Contributor

emilio commented Jan 27, 2017

Hmm... That seems pretty much wrong to me, can you file an issue on it?

@emilio
Copy link
Contributor

emilio commented Jan 27, 2017

I can't reproduce either fwiw, may be a 3.8 thing? (wat)

@fitzgen
Copy link
Member Author

fitzgen commented Jan 27, 2017

Filed #450

@bors-servo
Copy link

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 44ed608 into rust-lang:master Jan 27, 2017
@fitzgen fitzgen deleted the trace-constructors branch January 27, 2017 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants