New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace constructors #448
Trace constructors #448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
Sorry for not looking at whether we tracked them separately or not before, got sidetracked :)
@@ -978,5 +978,9 @@ impl TypeCollector for CompInfo { | |||
for method in self.methods() { | |||
types.insert(method.signature); | |||
} | |||
|
|||
for &ctor in self.constructors() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, so we did track them separately :)
@bors-servo r+ |
📌 Commit e9e561b has been approved by |
Hrm.... looks like we have a lot of unresolved type refs... Not sure why this didn't trigger locally :-/
|
This is a useful debugging tool for us to catch when code generation and whitelisting have different understandings of the world.
Trace constructors r? @emilio
e9e561b
to
44ed608
Compare
Trying without that commit. @bors-servo r=emilio |
📌 Commit 44ed608 has been approved by |
Trace constructors r? @emilio
Hmm... That seems pretty much wrong to me, can you file an issue on it? |
I can't reproduce either fwiw, may be a 3.8 thing? (wat) |
Filed #450 |
☀️ Test successful - status-travis |
r? @emilio