Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that every item is in some module's children list #770

Merged
merged 5 commits into from
Jun 21, 2017
Merged

Ensure that every item is in some module's children list #770

merged 5 commits into from
Jun 21, 2017

Commits on Jun 20, 2017

  1. Allow path separators in test-one.sh 

    Before this commit, test-one.sh was unusable with tests/headers/template.hpp
because there were too many things with "template.hpp" as a suffix. This allows
us to specify "/template.hpp" to run the test.
    @fitzgen
    fitzgen committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    26094ea View commit details
    Browse the repository at this point in the history

  2. Ensure that every item is in some module's children list 

    Previously, if an item's parent was not a module (eg a nested class definition
whose parent it the outer class definition) and the parent was not whitelisted
but the item was transitively whitelisted, then we could generate uses of the
item without emitting any definition for it. This could happen because we were
relying on the outer type calling for code generation on its inner types, but
that relies on us doing code generation for the outer type, which won't happen
if the outer type is not whitelisted.

This commit avoids this gotcha by ensuring that all items end up in a module's
children list, and so will be code generated even if their parent is not
whitelisted.

Fixes rust-lang#769
    @fitzgen
    fitzgen committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    979f5aa View commit details
    Browse the repository at this point in the history

  3. Add dotted lines from modules to children in IR visualization 

    There's a lot of these edges so it helps to make them un-bold.
    @fitzgen
    fitzgen committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    33272cd View commit details
    Browse the repository at this point in the history

  4. Assert that every item is a child of an ancestor module 

    This commit adds assertions that run when the "testing_only_extra_assertions"
feature is enabled, which make sure that every single item we parse is a child
of some ancestor module.
    @fitzgen
    fitzgen committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    c736faa View commit details
    Browse the repository at this point in the history

  5. Add a comment about template instantiation parentage

    @fitzgen
    fitzgen committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    5230565 View commit details
    Browse the repository at this point in the history