Dump preprocessed input headers #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than eagerly expanding multiple input headers into `-include <header>` clang arguments, store them explicitly until we actually go to generate bindings. Same deal for unsaved file contents.
This is useful when debugging bindgen, using C-Reduce on an input to bindgen, or for constructing portable test cases when filing issues against bindgen. Fixes rust-lang#811
It is both more correct and easier than using clang manually.
emilio
reviewed
Jul 14, 2017
| wrapper_contents.push_str(contents); | ||
| } | ||
|
|
||
| is_cpp |= self.options.clang_args.windows(2).any(|w| { |
There was a problem hiding this comment.
Won't this miss it if the last argument is -x=c++?
There was a problem hiding this comment.
Nope, that's what the w[1] check is there for. The windows iterator returns overlapping windows, so the last argument will always eventually be w[1].
emilio
approved these changes
Jul 14, 2017
|
@bors-servo r=emilio |
|
📌 Commit 618dafe has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit message.
Fixes #811.
r? @emilio