ir: When something has a definition, return unresolved type references until we parse it. #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fitzgen |
fitzgen
requested changes
Aug 23, 2017
src/ir/item.rs
Outdated
| let definition = cursor.definition(); | ||
| let applicable_cursor = definition.unwrap_or(cursor); | ||
|
|
||
| if definition.is_some() && definition != Some(cursor) { |
There was a problem hiding this comment.
Care to plop the commit message as a comment right here? I think that would help future readers of this code.
| @@ -73,6 +53,26 @@ fn bindgen_test_layout_A() { | |||
| impl Clone for A { | |||
| fn clone(&self) -> Self { *self } | |||
| } | |||
| #[repr(C)] | |||
| #[derive(Debug, Default, Copy, Hash, PartialEq, Eq)] | |||
| pub struct C { | |||
There was a problem hiding this comment.
This should still be A_C though, shouldn't it? I don't think this change is desirable.
class A {
public:
int member_a;
class B {
int member_b;
};
class C;
template<typename T>
class D {
T foo;
};
};
class A::C {
int baz;
};There was a problem hiding this comment.
Good catch here, thanks! I'll take a look tomorrow when I have the time.
…s until we parse it. This ensures that we see all the relevant types that are defined when parsing the definition, avoiding problems like rust-lang#888. Fixes rust-lang#888
|
I fixed that bit, can you re-review @fitzgen? |
|
@bors-servo r+ |
|
📌 Commit 8ecb50a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 5, 2017
ir: When something has a definition, return unresolved type references until we parse it. This fixes #888
|
☀️ Test successful - status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #888