Avoid lifetime annotation in struct example #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @marioidival (rust_highfive has picked a reviewer for you, use r? to override) |
xiaochuanyu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the options of addressing #1371.
The current example in Structure section uses lifetime annotation without any explanation.
In my opinion, using lifetime annotations so early on in the book may do more harm than good by confusing people. This PR makes it so that we avoids using lifetime annotations in the example all together similar to Rust programming language book https://doc.rust-lang.org/book/ch05-01-defining-structs.html.
It might be worthwhile to also have a lightweight section about ownership immediately after Structures section.