Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo and update some code samples #628

Merged
merged 2 commits into from Aug 7, 2015
Merged

Fix a typo and update some code samples #628

merged 2 commits into from Aug 7, 2015

Conversation

chriskrycho
Copy link
Contributor

  • Typo: add an apostrophe to a possessive that was missing it.
  • Code samples: switch from playpen to built-in sample type in all the file I/O examples, since their being editable is at best irrelevant and at worst confusing. Update the verbiage around them accordingly, no longer referencing the inability to run the samples in the playpen.

I took this route on these code samples to bring it in line with the FFI examples, which likewise do not use the playpen.

@chriskrycho
generics: Fix typo (possessive missing apostrophe).
8b136c8
@chriskrycho
std_misc/file: Use samples, not playpens, for I/O examples.
9d42d6b 
Since the file samples aren't runnable, making them editable is not
particularly useful. Moreover, until #73 is closed, it will also make
those pages much easier to read in the sepia and night reading modes.
@rust-highfive
Copy link

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik added a commit that referenced this pull request Aug 7, 2015
@steveklabnik
Merge pull request #628 from chriskrycho/typo_and_samples
24a8467 
Fix a typo and update some code samples
@steveklabnik steveklabnik merged commit 24a8467 into rust-lang:master Aug 7, 2015
@steveklabnik
Copy link
Member

Thanks!

@chriskrycho chriskrycho deleted the typo_and_samples branch August 8, 2015 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chriskrycho @rust-highfive @steveklabnik