Skip to content

Commit

Permalink
Update ui tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@GuillaumeGomez
GuillaumeGomez committed Feb 23, 2024
1 parent 20181c2 commit 4dc952c
Show file tree
Hide file tree
Showing 6 changed files with 52 additions and 49 deletions.
1 change: 1 addition & 0 deletions tests/ui/trait_duplication_in_bounds_unfixable.rs
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#![deny(clippy::trait_duplication_in_bounds)]
#![allow(clippy::multiple_bound_locations)]

use std::collections::BTreeMap;
use std::ops::{Add, AddAssign, Div, DivAssign, Mul, MulAssign, Sub, SubAssign};
Expand Down
16 changes: 8 additions & 8 deletions tests/ui/trait_duplication_in_bounds_unfixable.stderr
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: this trait bound is already specified in the where clause
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:6:15
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:7:15
|
LL | fn bad_foo<T: Clone + Default, Z: Copy>(arg0: T, arg1: Z)
| ^^^^^
Expand All @@ -12,55 +12,55 @@ LL | #![deny(clippy::trait_duplication_in_bounds)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: this trait bound is already specified in the where clause
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:6:23
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:7:23
|
LL | fn bad_foo<T: Clone + Default, Z: Copy>(arg0: T, arg1: Z)
| ^^^^^^^
|
= help: consider removing this trait bound

error: this trait bound is already specified in trait declaration
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:37:15
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:38:15
|
LL | Self: Default;
| ^^^^^^^
|
= help: consider removing this trait bound

error: this trait bound is already specified in trait declaration
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:52:15
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:53:15
|
LL | Self: Default + Clone;
| ^^^^^^^
|
= help: consider removing this trait bound

error: this trait bound is already specified in trait declaration
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:59:15
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:60:15
|
LL | Self: Default + Clone;
| ^^^^^^^
|
= help: consider removing this trait bound

error: this trait bound is already specified in trait declaration
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:59:25
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:60:25
|
LL | Self: Default + Clone;
| ^^^^^
|
= help: consider removing this trait bound

error: this trait bound is already specified in trait declaration
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:64:15
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:65:15
|
LL | Self: Default;
| ^^^^^^^
|
= help: consider removing this trait bound

error: this trait bound is already specified in trait declaration
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:100:15
--> tests/ui/trait_duplication_in_bounds_unfixable.rs:101:15
|
LL | Self: Iterator<Item = Foo>,
| ^^^^^^^^^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/type_repetition_in_bounds.rs
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#![deny(clippy::type_repetition_in_bounds)]
#![allow(clippy::extra_unused_type_parameters)]
#![allow(clippy::extra_unused_type_parameters, clippy::multiple_bound_locations)]

use serde::Deserialize;
use std::ops::{Add, AddAssign, Div, DivAssign, Mul, MulAssign, Sub, SubAssign};
Expand Down
1 change: 1 addition & 0 deletions tests/ui/unnecessary_cast.fixed
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#![warn(clippy::unnecessary_cast)]
#![allow(
clippy::borrow_as_ptr,
clippy::multiple_bound_locations,
clippy::no_effect,
clippy::nonstandard_macro_braces,
clippy::unnecessary_operation,
Expand Down
1 change: 1 addition & 0 deletions tests/ui/unnecessary_cast.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#![warn(clippy::unnecessary_cast)]
#![allow(
clippy::borrow_as_ptr,
clippy::multiple_bound_locations,
clippy::no_effect,
clippy::nonstandard_macro_braces,
clippy::unnecessary_operation,
Expand Down
80 changes: 40 additions & 40 deletions tests/ui/unnecessary_cast.stderr
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: casting raw pointers to the same type and constness is unnecessary (`*const T` -> `*const T`)
--> tests/ui/unnecessary_cast.rs:18:5
--> tests/ui/unnecessary_cast.rs:19:5
|
LL | ptr as *const T
| ^^^^^^^^^^^^^^^ help: try: `ptr`
Expand All @@ -8,235 +8,235 @@ LL | ptr as *const T
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`

error: casting integer literal to `i32` is unnecessary
--> tests/ui/unnecessary_cast.rs:53:5
--> tests/ui/unnecessary_cast.rs:54:5
|
LL | 1i32 as i32;
| ^^^^^^^^^^^ help: try: `1_i32`

error: casting float literal to `f32` is unnecessary
--> tests/ui/unnecessary_cast.rs:54:5
--> tests/ui/unnecessary_cast.rs:55:5
|
LL | 1f32 as f32;
| ^^^^^^^^^^^ help: try: `1_f32`

error: casting to the same type is unnecessary (`bool` -> `bool`)
--> tests/ui/unnecessary_cast.rs:55:5
--> tests/ui/unnecessary_cast.rs:56:5
|
LL | false as bool;
| ^^^^^^^^^^^^^ help: try: `false`

error: casting integer literal to `i32` is unnecessary
--> tests/ui/unnecessary_cast.rs:58:5
--> tests/ui/unnecessary_cast.rs:59:5
|
LL | -1_i32 as i32;
| ^^^^^^^^^^^^^ help: try: `-1_i32`

error: casting integer literal to `i32` is unnecessary
--> tests/ui/unnecessary_cast.rs:59:5
--> tests/ui/unnecessary_cast.rs:60:5
|
LL | - 1_i32 as i32;
| ^^^^^^^^^^^^^^ help: try: `- 1_i32`

error: casting float literal to `f32` is unnecessary
--> tests/ui/unnecessary_cast.rs:60:5
--> tests/ui/unnecessary_cast.rs:61:5
|
LL | -1f32 as f32;
| ^^^^^^^^^^^^ help: try: `-1_f32`

error: casting integer literal to `i32` is unnecessary
--> tests/ui/unnecessary_cast.rs:61:5
--> tests/ui/unnecessary_cast.rs:62:5
|
LL | 1_i32 as i32;
| ^^^^^^^^^^^^ help: try: `1_i32`

error: casting float literal to `f32` is unnecessary
--> tests/ui/unnecessary_cast.rs:62:5
--> tests/ui/unnecessary_cast.rs:63:5
|
LL | 1_f32 as f32;
| ^^^^^^^^^^^^ help: try: `1_f32`

error: casting raw pointers to the same type and constness is unnecessary (`*const u8` -> `*const u8`)
--> tests/ui/unnecessary_cast.rs:64:22
--> tests/ui/unnecessary_cast.rs:65:22
|
LL | let _: *mut u8 = [1u8, 2].as_ptr() as *const u8 as *mut u8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `[1u8, 2].as_ptr()`

error: casting raw pointers to the same type and constness is unnecessary (`*const u8` -> `*const u8`)
--> tests/ui/unnecessary_cast.rs:66:5
--> tests/ui/unnecessary_cast.rs:67:5
|
LL | [1u8, 2].as_ptr() as *const u8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `[1u8, 2].as_ptr()`

error: casting raw pointers to the same type and constness is unnecessary (`*mut u8` -> `*mut u8`)
--> tests/ui/unnecessary_cast.rs:68:5
--> tests/ui/unnecessary_cast.rs:69:5
|
LL | [1u8, 2].as_mut_ptr() as *mut u8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `[1u8, 2].as_mut_ptr()`

error: casting raw pointers to the same type and constness is unnecessary (`*const u32` -> `*const u32`)
--> tests/ui/unnecessary_cast.rs:79:5
--> tests/ui/unnecessary_cast.rs:80:5
|
LL | owo::<u32>([1u32].as_ptr()) as *const u32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `owo::<u32>([1u32].as_ptr())`

error: casting raw pointers to the same type and constness is unnecessary (`*const u8` -> `*const u8`)
--> tests/ui/unnecessary_cast.rs:80:5
--> tests/ui/unnecessary_cast.rs:81:5
|
LL | uwu::<u32, u8>([1u32].as_ptr()) as *const u8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `uwu::<u32, u8>([1u32].as_ptr())`

error: casting raw pointers to the same type and constness is unnecessary (`*const u32` -> `*const u32`)
--> tests/ui/unnecessary_cast.rs:82:5
--> tests/ui/unnecessary_cast.rs:83:5
|
LL | uwu::<u32, u32>([1u32].as_ptr()) as *const u32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `uwu::<u32, u32>([1u32].as_ptr())`

error: casting to the same type is unnecessary (`u32` -> `u32`)
--> tests/ui/unnecessary_cast.rs:117:5
--> tests/ui/unnecessary_cast.rs:118:5
|
LL | aaa() as u32;
| ^^^^^^^^^^^^ help: try: `aaa()`

error: casting to the same type is unnecessary (`u32` -> `u32`)
--> tests/ui/unnecessary_cast.rs:119:5
--> tests/ui/unnecessary_cast.rs:120:5
|
LL | aaa() as u32;
| ^^^^^^^^^^^^ help: try: `aaa()`

error: casting integer literal to `f32` is unnecessary
--> tests/ui/unnecessary_cast.rs:155:9
--> tests/ui/unnecessary_cast.rs:156:9
|
LL | 100 as f32;
| ^^^^^^^^^^ help: try: `100_f32`

error: casting integer literal to `f64` is unnecessary
--> tests/ui/unnecessary_cast.rs:156:9
--> tests/ui/unnecessary_cast.rs:157:9
|
LL | 100 as f64;
| ^^^^^^^^^^ help: try: `100_f64`

error: casting integer literal to `f64` is unnecessary
--> tests/ui/unnecessary_cast.rs:157:9
--> tests/ui/unnecessary_cast.rs:158:9
|
LL | 100_i32 as f64;
| ^^^^^^^^^^^^^^ help: try: `100_f64`

error: casting integer literal to `f32` is unnecessary
--> tests/ui/unnecessary_cast.rs:158:17
--> tests/ui/unnecessary_cast.rs:159:17
|
LL | let _ = -100 as f32;
| ^^^^^^^^^^^ help: try: `-100_f32`

error: casting integer literal to `f64` is unnecessary
--> tests/ui/unnecessary_cast.rs:159:17
--> tests/ui/unnecessary_cast.rs:160:17
|
LL | let _ = -100 as f64;
| ^^^^^^^^^^^ help: try: `-100_f64`

error: casting integer literal to `f64` is unnecessary
--> tests/ui/unnecessary_cast.rs:160:17
--> tests/ui/unnecessary_cast.rs:161:17
|
LL | let _ = -100_i32 as f64;
| ^^^^^^^^^^^^^^^ help: try: `-100_f64`

error: casting float literal to `f32` is unnecessary
--> tests/ui/unnecessary_cast.rs:161:9
--> tests/ui/unnecessary_cast.rs:162:9
|
LL | 100. as f32;
| ^^^^^^^^^^^ help: try: `100_f32`

error: casting float literal to `f64` is unnecessary
--> tests/ui/unnecessary_cast.rs:162:9
--> tests/ui/unnecessary_cast.rs:163:9
|
LL | 100. as f64;
| ^^^^^^^^^^^ help: try: `100_f64`

error: casting integer literal to `u32` is unnecessary
--> tests/ui/unnecessary_cast.rs:174:9
--> tests/ui/unnecessary_cast.rs:175:9
|
LL | 1 as u32;
| ^^^^^^^^ help: try: `1_u32`

error: casting integer literal to `i32` is unnecessary
--> tests/ui/unnecessary_cast.rs:175:9
--> tests/ui/unnecessary_cast.rs:176:9
|
LL | 0x10 as i32;
| ^^^^^^^^^^^ help: try: `0x10_i32`

error: casting integer literal to `usize` is unnecessary
--> tests/ui/unnecessary_cast.rs:176:9
--> tests/ui/unnecessary_cast.rs:177:9
|
LL | 0b10 as usize;
| ^^^^^^^^^^^^^ help: try: `0b10_usize`

error: casting integer literal to `u16` is unnecessary
--> tests/ui/unnecessary_cast.rs:177:9
--> tests/ui/unnecessary_cast.rs:178:9
|
LL | 0o73 as u16;
| ^^^^^^^^^^^ help: try: `0o73_u16`

error: casting integer literal to `u32` is unnecessary
--> tests/ui/unnecessary_cast.rs:178:9
--> tests/ui/unnecessary_cast.rs:179:9
|
LL | 1_000_000_000 as u32;
| ^^^^^^^^^^^^^^^^^^^^ help: try: `1_000_000_000_u32`

error: casting float literal to `f64` is unnecessary
--> tests/ui/unnecessary_cast.rs:180:9
--> tests/ui/unnecessary_cast.rs:181:9
|
LL | 1.0 as f64;
| ^^^^^^^^^^ help: try: `1.0_f64`

error: casting float literal to `f32` is unnecessary
--> tests/ui/unnecessary_cast.rs:181:9
--> tests/ui/unnecessary_cast.rs:182:9
|
LL | 0.5 as f32;
| ^^^^^^^^^^ help: try: `0.5_f32`

error: casting integer literal to `i32` is unnecessary
--> tests/ui/unnecessary_cast.rs:185:17
--> tests/ui/unnecessary_cast.rs:186:17
|
LL | let _ = -1 as i32;
| ^^^^^^^^^ help: try: `-1_i32`

error: casting float literal to `f32` is unnecessary
--> tests/ui/unnecessary_cast.rs:186:17
--> tests/ui/unnecessary_cast.rs:187:17
|
LL | let _ = -1.0 as f32;
| ^^^^^^^^^^^ help: try: `-1.0_f32`

error: casting to the same type is unnecessary (`i32` -> `i32`)
--> tests/ui/unnecessary_cast.rs:192:18
--> tests/ui/unnecessary_cast.rs:193:18
|
LL | let _ = &(x as i32);
| ^^^^^^^^^^ help: try: `{ x }`

error: casting integer literal to `i32` is unnecessary
--> tests/ui/unnecessary_cast.rs:198:22
--> tests/ui/unnecessary_cast.rs:199:22
|
LL | let _: i32 = -(1) as i32;
| ^^^^^^^^^^^ help: try: `-1_i32`

error: casting integer literal to `i64` is unnecessary
--> tests/ui/unnecessary_cast.rs:200:22
--> tests/ui/unnecessary_cast.rs:201:22
|
LL | let _: i64 = -(1) as i64;
| ^^^^^^^^^^^ help: try: `-1_i64`

error: casting float literal to `f64` is unnecessary
--> tests/ui/unnecessary_cast.rs:207:22
--> tests/ui/unnecessary_cast.rs:208:22
|
LL | let _: f64 = (-8.0 as f64).exp();
| ^^^^^^^^^^^^^ help: try: `(-8.0_f64)`

error: casting float literal to `f64` is unnecessary
--> tests/ui/unnecessary_cast.rs:209:23
--> tests/ui/unnecessary_cast.rs:210:23
|
LL | let _: f64 = -(8.0 as f64).exp(); // should suggest `-8.0_f64.exp()` here not to change code behavior
| ^^^^^^^^^^^^ help: try: `8.0_f64`

error: casting to the same type is unnecessary (`f32` -> `f32`)
--> tests/ui/unnecessary_cast.rs:217:20
--> tests/ui/unnecessary_cast.rs:218:20
|
LL | let _num = foo() as f32;
| ^^^^^^^^^^^^ help: try: `foo()`
Expand Down

0 comments on commit 4dc952c

Please sign in to comment.