join_absolute_paths: Address PR review

rust-lang · Nov 19, 2023 · f79f6ae · f79f6ae
1 parent b9433a6
commit f79f6ae
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/clippy_lints/src/methods/join_absolute_paths.rs b/clippy_lints/src/methods/join_absolute_paths.rs
@@ -17,7 +17,7 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, recv: &'tcx Expr<'tcx>, join_a
         && let ExprKind::Lit(spanned) = expr_or_init(cx, join_arg).kind
         && let LitKind::Str(symbol, _) = spanned.node
         && let sym_str = symbol.as_str()
-        && (sym_str.starts_with('/') || sym_str.starts_with('\\'))
+        && sym_str.starts_with(&['/', '\\'])
     {
         span_lint_and_then(
             cx,
@@ -42,7 +42,7 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, recv: &'tcx Expr<'tcx>, join_a
                     )
                     .span_suggestion(
                         expr_span,
-                        "if this is intentional, try creating a new Path instead",
+                        "if this is intentional, try using `Path::new` instead",
                         format!("PathBuf::from({arg_str})"),
                         Applicability::Unspecified,
                     );

diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs
@@ -3694,7 +3694,7 @@ declare_clippy_lint! {
     /// Note the behavior is platform dependent. A leading `\\` will be accepted
     /// on unix systems as part of the file name
     ///
-    /// See [`Path::join()`](https://doc.rust-lang.org/std/path/struct.Path.html#method.join)
+    /// See [`Path::join`](https://doc.rust-lang.org/std/path/struct.Path.html#method.join)
     ///
     /// ### Example
     /// ```rust

diff --git a/tests/ui/join_absolute_paths.stderr b/tests/ui/join_absolute_paths.stderr
@@ -11,7 +11,7 @@ help: if this is unintentional, try removing the starting separator
    |
 LL |     path.join("sh");
    |               ~~~~
-help: if this is intentional, try creating a new Path instead
+help: if this is intentional, try using `Path::new` instead
    |
 LL |     PathBuf::from("/sh");
    |     ~~~~~~~~~~~~~~~~~~~~
@@ -27,7 +27,7 @@ help: if this is unintentional, try removing the starting separator
    |
 LL |     path.join("\user");
    |               ~~~~~~~
-help: if this is intentional, try creating a new Path instead
+help: if this is intentional, try using `Path::new` instead
    |
 LL |     PathBuf::from("\\user");
    |     ~~~~~~~~~~~~~~~~~~~~~~~
@@ -43,7 +43,7 @@ help: if this is unintentional, try removing the starting separator
    |
 LL |     path.join("sh");
    |               ~~~~
-help: if this is intentional, try creating a new Path instead
+help: if this is intentional, try using `Path::new` instead
    |
 LL |     PathBuf::from("/sh");
    |     ~~~~~~~~~~~~~~~~~~~~
@@ -59,7 +59,7 @@ help: if this is unintentional, try removing the starting separator
    |
 LL |     path.join(r#"sh"#);
    |               ~~~~~~~
-help: if this is intentional, try creating a new Path instead
+help: if this is intentional, try using `Path::new` instead
    |
 LL |     PathBuf::from(r#"/sh"#);
    |     ~~~~~~~~~~~~~~~~~~~~~~~