Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary_fallible_conversions could show some more details #11753

Closed
matthiaskrgr opened this issue Nov 3, 2023 · 1 comment · Fixed by #11767
Closed

unnecessary_fallible_conversions could show some more details #11753

matthiaskrgr opened this issue Nov 3, 2023 · 1 comment · Fixed by #11767
Assignees
@matthri
Labels
L-suggestion Lint: Improving, adding or fixing lint suggestions

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Nov 3, 2023 •
edited by rustbot

Description

current output is just use of a fallible conversion when an infallible one could be used

It would be nice to show a couple more details, maybe something like converting 'i32' to 'i64' which cannot fail

Version

rustc 1.75.0-nightly (9c20ddd95 2023-11-03)
binary: rustc
commit-hash: 9c20ddd956426d577d77cb3f57a7db2227a3c6e9
commit-date: 2023-11-03
host: x86_64-unknown-linux-gnu
release: 1.75.0-nightly
LLVM version: 17.0.4

Additional Labels

No response
@matthiaskrgr matthiaskrgr added the L-suggestion Lint: Improving, adding or fixing lint suggestions label Nov 3, 2023
@matthiaskrgr matthiaskrgr changed the title unnecessary_fallible_conversions could show some more details unnecessary_fallible_conversions could show some more details Nov 3, 2023
@matthri
Copy link
Contributor

matthri commented Nov 3, 2023

@rustbot claim

@matthri matthri mentioned this issue Nov 7, 2023
Merged
bors added a commit that referenced this issue Nov 11, 2023
@bors
Auto merge of #11767 - matthri:unnecessary-fallible-conversions-ext-n…
6148447 
…otes, r=blyxyas

Add type details to unnecessary_fallible_conversions note

fixes: #11753

changelog: [`unnecessary_fallible_conversions`]: add type details to lint note
@bors bors closed this as completed in 8ee9a9c Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthri matthri

Labels
L-suggestion Lint: Improving, adding or fixing lint suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type details to unnecessary_fallible_conversions note matthri/rust-clippy
2 participants
@matthiaskrgr @matthri