foo.unwrap_or(panic!(…))

[ftxqxd]

This should either be .expect() or .unwrap_or_else(|| panic!()) (if they want the formatting panic provides). Ideally this would be generalised to any diverging function (fn(…) -> !) as well.

[lambda-fairy]

Note that macro expansion runs before type checking runs before lints, so we'll need to match against std::rt::begin_unwind and friends instead.

[llogiq]

Similarly, one can implement a lot of Option's API in terms of itself. A number of hints to use the right one will certainly be helpful for a number of people.

[camsteffen]

I would generalize this to suspicious_panic_position and lint anything weird like Foo { field: panic!() } or any_function(.., panic!(), ..).

[bugadani]

This seems to boil down to seeing the never type (!) used basically anywhere except expression statements? I would call anything suspicious that doesn't return but gets assigned to something - todo!(), variations of unreachable, asserts?.