Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the rustc submodule #2700

Closed
oli-obk opened this issue Apr 27, 2018 · 3 comments
Closed

update the rustc submodule #2700

oli-obk opened this issue Apr 27, 2018 · 3 comments
Labels
good-first-issue These issues are a good way to get started with Clippy

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Apr 27, 2018

I won't get to it anytime soon. All that's needed is to point the submodule (src/tools/clippy) in the rustc repo to the master branch of this repo and run the x.py script to update the Cargo.lock and open a pr with said changes
@oli-obk oli-obk added the good-first-issue These issues are a good way to get started with Clippy label Apr 27, 2018
@phansch
Copy link
Member

phansch commented Apr 27, 2018

Will give this a try today 👍

@phansch
Copy link
Member

phansch commented Apr 28, 2018

This would require a new clippy release, no?
I manged to update the submodule, but running cargo update -p clippy makes no changes

@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 28, 2018

Should be fine. Releases of submodules make no difference if no dependencies changed. Try running. /x.py without any args (after git add-ing the submodule).

@phansch phansch mentioned this issue Apr 28, 2018
Merged
bors added a commit to rust-lang/rust that referenced this issue Apr 29, 2018
@bors
Auto merge of #50300 - phansch:update_clippy, r=oli-obk
d450f99 
Update clippy

First time doing this. Not sure if this is enough as the docs mention that the Cargo.lock should be updated, however running `cargo update -p clippy` and `./x.py` doesn't change anything.

Closes rust-lang/rust-clippy#2700

r? @oli-obk
@phansch phansch closed this as completed Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @phansch