Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate warnings after rustup fix #3710

Closed
phansch opened this issue Jan 28, 2019 · 2 comments
Closed

Duplicate warnings after rustup fix #3710

phansch opened this issue Jan 28, 2019 · 2 comments
Labels
C-bug Category: Clippy is not doing the correct thing L-suggestion Lint: Improving, adding or fixing lint suggestions

Comments

@phansch
Copy link
Member

phansch commented Jan 28, 2019

The ui/deprecated.stderr and ui/rename.stderr contain duplicate lint emissions in two cases after rustup to rust-lang/rust#57726.

I think the reason for the duplicates is this change here:
https://github.com/rust-lang/rust/blob/9b5535a6f38340d3be8fcae1822a04ba3febf82f/src/librustc/lint/context.rs#L1325
They now run early_lint_crate twice. Once with the builtin lints and once with the registered lint passes. Those warnings aren't generated by a normal lint but rather when the lints are looked up from attributes which happens twice now.
I'm not sure why only the first is duplicated though. Maybe because they filter duplicates but the first one has a note. 🤔

Originally posted by @mikerite in #3705 (comment)

@phansch phansch added C-bug Category: Clippy is not doing the correct thing L-suggestion Lint: Improving, adding or fixing lint suggestions labels Jan 28, 2019
@flip1995
Copy link
Member

Maybe because they filter duplicates but the first one has a note.

I ran into that myself before. Can confirm that this is an issue: rust-lang/rust#53762 (comment)

The weird thing is, that it only happens on some lints and not on all lints.

@camsteffen
Copy link
Contributor

This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing L-suggestion Lint: Improving, adding or fixing lint suggestions
Projects
None yet
Development

No branches or pull requests

3 participants