New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all builtin early lints #57726

Merged
merged 2 commits into from Jan 26, 2019

Conversation

Projects
None yet
4 participants
@Zoxc
Copy link
Contributor

Zoxc commented Jan 18, 2019

This also adds a -Z no-interleave-lints option to allow benchmarking lints.

r? @estebank

@@ -1131,7 +1135,7 @@ where
});

time(sess, "early lint checks", || {
lint::check_ast_crate(sess, &krate, false)
lint::check_ast_crate(sess, &krate, false, rustc_lint::BuiltinCombinedEarlyLintPass::new())

This comment has been minimized.

@Zoxc

Zoxc Jan 18, 2019

Author Contributor

This is not the same instance used to register the lints. I don't think that matters for the lints in rustc though.

This comment has been minimized.

@estebank

estebank Jan 25, 2019

Contributor

Let's continue forward with this under the assumption that it will be ok.

@Zoxc Zoxc force-pushed the Zoxc:combine-early-lints branch from 3041cf5 to cc755b7 Jan 18, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 18, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:036d74e8:start=1547802827757909398,finish=1547802828821594915,duration=1063685517
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:53] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:54] tidy error: /checkout/src/librustc/lint/mod.rs:356: trailing whitespace
[00:03:55] some tidy checks failed
[00:03:55] 
[00:03:55] 
[00:03:55] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:55] 
[00:03:55] 
[00:03:55] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:55] Build completed unsuccessfully in 0:00:46
[00:03:55] Build completed unsuccessfully in 0:00:46
[00:03:55] Makefile:69: recipe for target 'tidy' failed
[00:03:55] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:16f938c2
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Jan 18 09:17:56 UTC 2019
---
travis_time:end:07e76d20:start=1547803077037488334,finish=1547803077042412464,duration=4924130
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:085156f5
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:027919d4
travis_time:start:027919d4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2510c440
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc Zoxc force-pushed the Zoxc:combine-early-lints branch from cc755b7 to 5d3ad6c Jan 18, 2019

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 18, 2019

@Zoxc you'll need to fix your tests.

@Zoxc Zoxc force-pushed the Zoxc:combine-early-lints branch from 5d3ad6c to 72743e4 Jan 19, 2019

Combine all builtin early lints and use a separate walk for plugin li…
…nts. Add a -Z no-interleave-lints option to allow benchmarking lints

@Zoxc Zoxc force-pushed the Zoxc:combine-early-lints branch from 72743e4 to beb0c74 Jan 19, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 19, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:09886fe0:start=1547870573569843708,finish=1547870575825267427,duration=2255423719
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:12:49] 
[01:12:49] running 118 tests
[01:13:17] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:13:22] ......iii.i.....ii
[01:13:22] 
[01:13:22]  finished in 33.650
[01:13:22] travis_fold:end:test_debuginfo

---
travis_time:start:test_ui-fulldeps
Check compiletest suite=ui-fulldeps mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:13:23] 
[01:13:23] running 25 tests
[01:14:00] ....FFFFFFFFFFFF.........
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/issue-15778-fail.rs stdout ----
[01:14:00] 
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_for_crate.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_for_crate.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/issue-15778-fail/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/issue-15778-fail/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"unused import: `LateLintPassObject`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_for_crate.rs","byte_start":235,"byte_end":253,"line_start":10,"line_end":10,"column_start":69,"column_end":87,"is_primary":true,"text":[{"text":"use rustc::lint::{LateContext, LintContext, LintPass, LateLintPass, LateLintPassObject, LintArray};","highlight_start":69,"highlight_end":87}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"#[warn(unused_imports)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: unused import: `LateLintPassObject`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_for_crate.rs:10:69\n   |\nLL | use rustc::lint::{LateContext, LintContext, LintPass, LateLintPass, LateLintPassObject, LintArray};\n   |                                                                     ^^^^^^^^^^^^^^^^^^\n   |\n   = note: #[warn(unused_imports)] on by default\n\n"}
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_for_crate.rs","byte_start":422,"byte_end":444,"line_start":19,"line_end":19,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_for_crate.rs:19:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/issue-15778-fail.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-group-plugin-deny-cmdline.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-group-plugin-deny-cmdline/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-group-plugin-deny-cmdline/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"unused import: `LateLintPassObject`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs","byte_start":271,"byte_end":289,"line_start":12,"line_end":12,"column_start":69,"column_end":87,"is_primary":true,"text":[{"text":"use rustc::lint::{LateContext, LintContext, LintPass, LateLintPass, LateLintPassObject, LintArray};","highlight_start":69,"highlight_end":87}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"#[warn(unused_imports)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: unused import: `LateLintPassObject`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs:12:69\n   |\nLL | use rustc::lint::{LateContext, LintContext, LintPass, LateLintPass, LateLintPassObject, LintArray};\n   |                                                                     ^^^^^^^^^^^^^^^^^^\n   |\n   = note: #[warn(unused_imports)] on by default\n\n"}
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs","byte_start":490,"byte_end":512,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-group-plugin-deny-cmdline.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-group-plugin.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-group-plugin/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-group-plugin/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"unused import: `LateLintPassObject`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs","byte_start":271,"byte_end":289,"line_start":12,"line_end":12,"column_start":69,"column_end":87,"is_primary":true,"text":[{"text":"use rustc::lint::{LateContext, LintContext, LintPass, LateLintPass, LateLintPassObject, LintArray};","highlight_start":69,"highlight_end":87}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"#[warn(unused_imports)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: unused import: `LateLintPassObject`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs:12:69\n   |\nLL | use rustc::lint::{LateContext, LintContext, LintPass, LateLintPass, LateLintPassObject, LintArray};\n   |                                                                     ^^^^^^^^^^^^^^^^^^\n   |\n   = note: #[warn(unused_imports)] on by default\n\n"}
[01:14:00] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:495:22
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs","byte_start":490,"byte_end":512,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_group_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-group-plugin.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-plugin-cmdline-allow.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-cmdline-allow/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-cmdline-allow/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs","byte_start":456,"byte_end":478,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-plugin-cmdline-allow.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-plugin-cmdline-load.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-cmdline-load/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-cmdline-load/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs","byte_start":456,"byte_end":478,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-plugin-cmdline-load.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-plugin-deny-attr.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-deny-attr/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-deny-attr/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs","byte_start":456,"byte_end":478,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-plugin-deny-attr.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-plugin-deny-cmdline.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-deny-cmdline/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-deny-cmdline/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs","byte_start":456,"byte_end":478,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-plugin-deny-cmdline.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-plugin-forbid-attrs.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-forbid-attrs/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-forbid-attrs/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs","byte_start":456,"byte_end":478,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-plugin-forbid-attrs.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-plugin-forbid-cmdline.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-forbid-cmdline/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin-forbid-cmdline/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs","byte_start":456,"byte_end":478,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-plugin-forbid-cmdline.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint-plugin.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint-plugin/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs","byte_start":456,"byte_end":478,"line_start":21,"line_end":21,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_plugin_test.rs:21:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint-plugin.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint_tool_cmdline_allow.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_tool_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_tool_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint_tool_cmdline_allow/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint_tool_cmdline_allow/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_tool_test.rs","byte_start":498,"byte_end":520,"line_start":20,"line_end":20,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_tool_test.rs:20:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] 
[01:14:00] thread '[ui] ui-fulldeps/lint_tool_cmdline_allow.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3245:9
[01:14:00] 
[01:14:00] ---- [ui] ui-fulldeps/lint_tool_test.rs stdout ----
[01:14:00] 
[01:14:00] error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/lint_tool_test.rs" failed to compile: 
[01:14:00] status: exit code: 1
[01:14:00] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/lint_tool_test.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint_tool_test/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/lint_tool_test/auxiliary"
[01:14:00] ------------------------------------------
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] stderr:
[01:14:00] stderr:
[01:14:00] ------------------------------------------
[01:14:00] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/auxiliary/lint_tool_test.rs","byte_start":498,"byte_end":520,"line_start":20,"line_end":20,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"impl LintPass for Pass {","highlight_start":1,"highlight_end":23}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/ui-fulldeps/auxiliary/lint_tool_test.rs:20:1\n   |\nLL | impl LintPass for Pass {\n   | ^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:14:00] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:14:00] 
[01:14:00] ------------------------------------------
[01:14:00] 
---
[01:14:00] test result: FAILED. 13 passed; 12 failed; 0 ignored; 0 measured; 0 filtered out
[01:14:00] 
[01:14:00] 
[01:14:00] 
[01:14:00] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:14:00] 
[01:14:00] 
[01:14:00] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:14:00] Build completed unsuccessfully in 0:13:33
[01:14:00] Build completed unsuccessfully in 0:13:33
[01:14:00] Makefile:48: recipe for target 'check' failed
[01:14:00] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0e533411
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Jan 19 05:17:08 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 19, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:06f21b4c:start=1547875687958733691,finish=1547875688840566040,duration=881832349
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:15:48] 
[01:15:48] running 118 tests
[01:16:13] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:16:17] ......iii.i.....ii
[01:16:17] 
[01:16:17]  finished in 28.442
[01:16:17] travis_fold:end:test_debuginfo

---
travis_time:start:test_run-pass-fulldeps
Check compiletest suite=run-pass-fulldeps mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:16:57] 
[01:16:57] running 60 tests
[01:19:04] ...........................F...............................test [run-pass] run-pass-fulldeps/myriad-closures.rs has been running for over 60 seconds
[01:21:30] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:495:22
[01:21:30] failures:
[01:21:30] 
[01:21:30] ---- [run-pass] run-pass-fulldeps/issue-40001.rs stdout ----
[01:21:30] ---- [run-pass] run-pass-fulldeps/issue-40001.rs stdout ----
[01:21:30] 
[01:21:30] error: auxiliary build of "/checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs" failed to compile: 
[01:21:30] status: exit code: 1
[01:21:30] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/issue-40001/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/issue-40001/auxiliary"
[01:21:30] ------------------------------------------
[01:21:30] 
[01:21:30] ------------------------------------------
[01:21:30] stderr:
[01:21:30] stderr:
[01:21:30] ------------------------------------------
[01:21:30] {"message":"unused import: `syntax::ext::base::*`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs","byte_start":223,"byte_end":243,"line_start":11,"line_end":11,"column_start":5,"column_end":25,"is_primary":true,"text":[{"text":"use syntax::ext::base::*;","highlight_start":5,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"#[warn(unused_imports)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: unused import: `syntax::ext::base::*`\n  --> /checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs:11:5\n   |\nLL | use syntax::ext::base::*;\n   |     ^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: #[warn(unused_imports)] on by default\n\n"}
[01:21:30] {"message":"unused import: `syntax::symbol::Symbol`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs","byte_start":303,"byte_end":325,"line_start":13,"line_end":13,"column_start":5,"column_end":27,"is_primary":true,"text":[{"text":"use syntax::symbol::Symbol;","highlight_start":5,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: unused import: `syntax::symbol::Symbol`\n  --> /checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs:13:5\n   |\nLL | use syntax::symbol::Symbol;\n   |     ^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:21:30] {"message":"unused import: `rustc::hir::map as hir_map`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs","byte_start":376,"byte_end":402,"line_start":17,"line_end":17,"column_start":5,"column_end":31,"is_primary":true,"text":[{"text":"use rustc::hir::map as hir_map;","highlight_start":5,"highlight_end":31}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: unused import: `rustc::hir::map as hir_map`\n  --> /checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs:17:5\n   |\nLL | use rustc::hir::map as hir_map;\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:21:30] {"message":"unused import: `rustc::ty`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs","byte_start":503,"byte_end":512,"line_start":20,"line_end":20,"column_start":5,"column_end":14,"is_primary":true,"text":[{"text":"use rustc::ty;","highlight_start":5,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: unused import: `rustc::ty`\n  --> /checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs:20:5\n   |\nLL | use rustc::ty;\n   |     ^^^^^^^^^\n\n"}
[01:21:30] {"message":"not all trait items implemented, missing: `name`","code":{"code":"E0046","explanation":"\nItems are missing in a trait implementation. Erroneous code example:\n\n```compile_fail,E0046\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {}\n// error: not all trait items implemented, missing: `foo`\n```\n\nWhen trying to make some type implement a trait `Foo`, you must, at minimum,\nprovide implementations for all of `Foo`'s required methods (meaning the\nmethods that do not have default implementations), as well as any required\ntrait items like associated types or constants. Example:\n\n```\ntrait Foo {\n    fn foo();\n}\n\nstruct Bar;\n\nimpl Foo for Bar {\n    fn foo() {} // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs","byte_start":902,"byte_end":946,"line_start":34,"line_end":34,"column_start":1,"column_end":45,"is_primary":true,"text":[{"text":"impl LintPass for MissingWhitelistedAttrPass {","highlight_start":1,"highlight_end":45}],"label":"missing `name` in implementation","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`name` from trait: `fn(&Self) -> &'static str`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0046]: not all trait items implemented, missing: `name`\n  --> /checkout/src/test/run-pass-fulldeps/auxiliary/issue-40001-plugin.rs:34:1\n   |\nLL | impl LintPass for MissingWhitelistedAttrPass {\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation\n   |\n   = note: `name` from trait: `fn(&Self) -> &'static str`\n\n"}
[01:21:30] {"message":"For more information about this error, try `rustc --explain E0046`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0046`.\n"}
[01:21:30] 
[01:21:30] ------------------------------------------
[01:21:30] 
---
[01:21:30] test result: FAILED. 59 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:21:30] 
[01:21:30] 
[01:21:30] 
[01:21:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:21:30] 
[01:21:30] 
[01:21:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:21:30] Build completed unsuccessfully in 0:17:38
[01:21:30] Build completed unsuccessfully in 0:17:38
[01:21:30] Makefile:48: recipe for target 'check' failed
[01:21:30] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1663ab30
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Jan 19 06:49:50 UTC 2019
---
175672 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc
162608 ./obj/build/bootstrap/debug/incremental
153284 ./src/tools/clang
146492 ./obj/build/bootstrap/debug/incremental/bootstrap-1o7ipylf5x405
146488 ./obj/build/bootstrap/debug/incremental/bootstrap-1o7ipylf5x405/s-f8occr0lml-1k96bct-3sgufgpmw18gi
139060 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu
139056 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release
136716 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps
124936 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc Zoxc force-pushed the Zoxc:combine-early-lints branch from 77ea610 to 9b5535a Jan 19, 2019

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 24, 2019

I'll review this soon.

@@ -60,6 +60,10 @@ declare_lint! {
pub struct WhileTrue;

impl LintPass for WhileTrue {

This comment has been minimized.

@estebank

estebank Jan 25, 2019

Contributor

All of these look like they could use a macro.

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 25, 2019

This looks reasonable to me.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 25, 2019

📌 Commit 9b5535a has been approved by estebank

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 26, 2019

⌛️ Testing commit 9b5535a with merge ccd428b...

bors added a commit that referenced this pull request Jan 26, 2019

Auto merge of #57726 - Zoxc:combine-early-lints, r=estebank
Combine all builtin early lints

This also adds a -Z no-interleave-lints option to allow benchmarking lints.

r? @estebank
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing ccd428b to master...

@bors bors merged commit 9b5535a into rust-lang:master Jan 26, 2019

1 check passed

homu Test successful
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 26, 2019

📣 Toolstate changed by #57726!

Tested on commit ccd428b.
Direct link to PR: #57726

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jan 26, 2019

📣 Toolstate changed by rust-lang/rust#57726!
Tested on commit rust-lang/rust@ccd428b.
Direct link to PR: <rust-lang/rust#57726>

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).

@Zoxc Zoxc deleted the Zoxc:combine-early-lints branch Jan 26, 2019

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 26, 2019

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 26, 2019

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 27, 2019

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 27, 2019

@matthiaskrgr matthiaskrgr referenced this pull request Jan 27, 2019

Merged

rustup #3705

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jan 27, 2019

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2019

submodules: update clippy from f1753522 to 13421e39
Changes:
````
update test stderr
run cargo fmt
rustup rust-lang#57907
rustup rust-lang#57726
Remove unsafe_vector_initialization from added lints
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2019

submodules: update clippy from f1753522 to 13421e39
Changes:
````
update test stderr
run cargo fmt
rustup rust-lang#57907
rustup rust-lang#57726
Remove unsafe_vector_initialization from added lints
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 28, 2019

submodules: update clippy from f1753522 to 13421e39
Changes:
````
update test stderr
run cargo fmt
rustup rust-lang#57907
rustup rust-lang#57726
Remove unsafe_vector_initialization from added lints
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 28, 2019

submodules: update clippy from f1753522 to 4a2116b3
Changes:
````
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup rust-lang#57907
Fix documentation for `slow_vector_initialization`
rustup rust-lang#57726
Remove unsafe_vector_initialization from added lints
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

bors added a commit that referenced this pull request Jan 29, 2019

Auto merge of #57932 - matthiaskrgr:clippy_submodule_upd, r=oli-obk
submodules: update clippy and rls

Should fix clippy and rls toolstate

clippy changes:
````
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup #57907
Fix documentation for `slow_vector_initialization`
rustup #57726
Remove unsafe_vector_initialization from added lints
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````
rls changes:
````
Remove extra backticks in contributing.md
Bump rand from 0.6.4 to 0.6.5
Add how RLS can be built without clippy_lints
rustup #57907
update clippy to 13421e39
Replace crate with pub(crate)
Remove crate_visibility_modifier feature
Bump tokio from 0.1.14 to 0.1.15
Update clippy_lints
Bump tokio-timer from 0.2.8 to 0.2.9
Link to crates' source in relevant subheadings
Apply review feedback
Link to architecture.md from README and contributing doc
Apply suggestions from code review
Bump lsp-types from 0.55.0 to 0.55.1
Update cargo_metadata -> 0.7
Bump cargo_metadata from 0.6.4 to 0.7.0
Link to mentioned crates
Initial draft
Architecture plan
Bump serde_json from 1.0.36 to 1.0.37
tests: Only request Racer completion once
dependabot: Explicitly list default allowed_updates
dependabot: Add automerge strategy for clippy_lints
Bump lsp-types from 0.54.0 to 0.55.0
use serde:🇩🇪:Deserialize;
Translate test_deglob
Update clippy
Fix definitions test
Ensure we always wait with a timeout
Translate client_lens_run and find_definitions
Translate format_utf16_range
Translate handle_utf16_unit_text_edits
Translate invalid_member_dependency_resolution
Translate invalid_member_toml_manifest
Translate invalid_toml_manifest
Translate client_dependency_typo_and_fix
Translate test_use_statement_completion_doesnt_suggest_arguments
Translate completion_suggests_arguments_in_statements
Translate cmd_test_complete_self_crate_name
Translate implicit_workspace_pick_up_lib_changes
Translate cmd_changing_workspace_lib_retains_diagnostics
Translate infer_bin
Allow to wait for diagnostics message
Add note about double builds from didSave
Fix test learn_client_use_change_watched on Windows
Support textDocument/didSave manifest cargo rebuilds
Add missing clippy_lints register calls
Bump RLS version to 1.33
tests: Add a test for #57462 and go-to-definition without racer in general.
````

r? @oli-obk

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 29, 2019

submodules: update clippy from f1753522 to 3d646f6a
Changes:
````
Fix `unit_arg` false positive
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup rust-lang#57907
Fix documentation for `slow_vector_initialization`
rustup rust-lang#57726
Remove unsafe_vector_initialization from added lints
Prevent incorrect cast_lossless suggestion in const_fn
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 29, 2019

submodules: update clippy from f1753522 to 3d646f6a
Changes:
````
Fix `unit_arg` false positive
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup rust-lang#57907
Fix documentation for `slow_vector_initialization`
rustup rust-lang#57726
Remove unsafe_vector_initialization from added lints
Prevent incorrect cast_lossless suggestion in const_fn
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 30, 2019

submodules: update clippy from f1753522 to 6ce78d12
Changes:
````
wildcard_match_arm: Update lint count.
wildcard_match_arm: add nesting issue to known.
wildcard_match_arm: lint only enum matches.
wildcard_match_arm: update ui test stderr
wildcard_match_arm: format test.
wilcard_match_arm: run rustfmt.
wildcard_match_arm: add lint properly.
wildcard_match_arm: rename function.
wildcard_match_arm: add simple ui test.
wildcard_match_arm: expand lint scope.
Change match_wild lint name to WILDCARD_MATCH_ARM.
Add match_wild lint (rust-lang#3649).
fetch_prs_between: add .sh file ending
cargo fmt
Update various docs
Use built-in entry_fn detection over self-built
cargo fmt
Reorganize conditionals: Run faster checks first
Maybe fix ICE?
Add initial version of const_fn lint
Fix `unit_arg` false positive
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup rust-lang#57907
Fix documentation for `slow_vector_initialization`
rustup rust-lang#57726
Remove unsafe_vector_initialization from added lints
Prevent incorrect cast_lossless suggestion in const_fn
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

bors added a commit that referenced this pull request Jan 30, 2019

Auto merge of #57932 - matthiaskrgr:clippy_submodule_upd, r=oli-obk
submodules: update clippy from f1753522 to 6ce78d12

Should fix clippy toolstate

Changes:
````
wildcard_match_arm: Update lint count.
wildcard_match_arm: add nesting issue to known.
wildcard_match_arm: lint only enum matches.
wildcard_match_arm: update ui test stderr
wildcard_match_arm: format test.
wilcard_match_arm: run rustfmt.
wildcard_match_arm: add lint properly.
wildcard_match_arm: rename function.
wildcard_match_arm: add simple ui test.
wildcard_match_arm: expand lint scope.
Change match_wild lint name to WILDCARD_MATCH_ARM.
Add match_wild lint (#3649).
fetch_prs_between: add .sh file ending
cargo fmt
Update various docs
Use built-in entry_fn detection over self-built
cargo fmt
Reorganize conditionals: Run faster checks first
Maybe fix ICE?
Add initial version of const_fn lint
Fix `unit_arg` false positive
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup #57907
Fix documentation for `slow_vector_initialization`
rustup #57726
Remove unsafe_vector_initialization from added lints
Prevent incorrect cast_lossless suggestion in const_fn
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

r? @oli-obk

g-bartoszek added a commit to g-bartoszek/rust-clippy that referenced this pull request Feb 5, 2019

g-bartoszek added a commit to g-bartoszek/rust-clippy that referenced this pull request Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment