Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogfood: unicode-normalization takes 3 minutes to check #4782

Open
matthiaskrgr opened this issue Nov 6, 2019 · 1 comment
Open

dogfood: unicode-normalization takes 3 minutes to check #4782

matthiaskrgr opened this issue Nov 6, 2019 · 1 comment

Comments

@matthiaskrgr
Copy link
Member

During the dogfood test ,clippy is run on itself to make sure its code has no clippy warnings.
During this process, clippy checks all the dependencies as well, however I think this may actually not be needed.

On my system, I can see that checking the unicode-normalization crate using clippy takes 2-3 minutes alone yet a simple "cargo check" of clippy seems to be much faster.

Perhaps we can somehow "cargo check" the dependencies in the dogfood test and only check the actual repo sourcecode using clippy for a decent dogfood speedup?

@flip1995
Copy link
Member

flip1995 commented Nov 7, 2019

Maybe this is also a problem, which will be solved with #3837.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants