match_ref_pats should lint against if let (ref x) = *x

[Luro02]

This is pointless and has no benefit:

if let ErrorKind::Multiple(ref items) = *self

This is how it should be written

if let ErrorKind::Multiple(items) = &self

[matthiaskrgr]

Similar case:

enum Wrapper {
    A(String),
    B(String),
    C(String),
}

impl Wrapper {
    fn inner(&self) -> &String {
        match self {
            &Wrapper::A(ref inner) => inner,
            &Wrapper::B(ref inner) => inner,
            &Wrapper::C(ref inner) => inner,
        }
    }
}

Clippy suggests

match *self  {
   Wrapper::A(ref inner) => inner,
   ...

But it it would be better to suggest

   fn inner(&self) -> &String {
        match self {
            Wrapper::A(inner) => inner,
            Wrapper::B(inner) => inner,
            Wrapper::C(inner) => inner,
        }
    }

[Tanja-4732]

Has the suggestion from @matthiaskrgr been implemented yet? What's the status on it?

Clippy still suggests the asterisk both in stable and nightly:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e5449fb7e2e56fecb09556aba25c7cc6
https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=e5449fb7e2e56fecb09556aba25c7cc6

Steps to reproduce:

1. Open (either or both) link(s) from above
2. Click "Tools" on the top-right corner of the screen
3. Click on "Clippy" (an wait)

Some questions

• Will this be fixed?
• If so, when?
• Should a new issue be opened?

---

PS: also referencing #4961