Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: use rust-version field #8746

Closed
hellow554 opened this issue Apr 25, 2022 · 0 comments · Fixed by #8774
Closed

Suggestion: use rust-version field #8746

hellow554 opened this issue Apr 25, 2022 · 0 comments · Fixed by #8774
Labels
T-cargo Type: cargo related

Comments

@hellow554
Copy link
Contributor

Description

There is a "new" field in the Cargo.toml that can be used to specify the minimum supported rust version: rust-version

This feels somewhat redundant to the msrv in the clippy.toml file: https://github.com/rust-lang/rust-clippy/blob/master/README.md#specifying-the-minimum-supported-rust-version

If I see it correctly, clippy currently ignores the rust-version field from Cargo.toml.

Would it be a good approach to take that field into account when searching for a msrv?

Version

rustc 1.62.0-nightly (18f314e70 2022-04-24)
binary: rustc
commit-hash: 18f314e7027fe7084aaab8620c624a0d7bd29e70
commit-date: 2022-04-24
host: x86_64-unknown-linux-gnu
release: 1.62.0-nightly
LLVM version: 14.0.1

Additional Labels

@rustbot modify labels: A-clippy T-cargo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-cargo Type: cargo related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

try reading rust-version from Cargo.toml hellow554/rust-clippy
2 participants
@hellow554 @rustbot