Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

want to lint binary_heap in manual_retain when API is stabilized #9059

Closed
kyoto7250 opened this issue Jun 27, 2022 · 2 comments · Fixed by #11329
Closed

want to lint binary_heap in manual_retain when API is stabilized #9059

kyoto7250 opened this issue Jun 27, 2022 · 2 comments · Fixed by #11329
Assignees
@unvalley
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy

Comments

@kyoto7250
Copy link
Contributor

kyoto7250 commented Jun 27, 2022 •
edited by rustbot

Description

I created manual_retain, but binary_heap_retain method is nightly API now, so we do not lint.

When this API is stabilized, we should lint binary_heap_retain as well.
It will work if we rewrite the process a little and add some tests.

If you have any questions, please ask me.

ref:

Version

No response

Additional Labels

@rustbot label +C-enhancement +good-first-issue
@rustbot rustbot added C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy labels Jun 27, 2022
@JohnTitor JohnTitor mentioned this issue Jul 21, 2022
Closed
@bluthej bluthej mentioned this issue Mar 30, 2023
Closed
@unvalley
Copy link
Contributor

It seems that binary_heap_retain API is stabilized in the PR (but not shipped yet). I'm interested in working on this.

@unvalley
Copy link
Contributor

@rustbot claim

@unvalley unvalley mentioned this issue Aug 12, 2023
Merged
@bors bors closed this as completed in 344ae11 Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unvalley unvalley

Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[manual_retain]: add lint case for binary_heap unvalley/rust-clippy
3 participants
@unvalley @rustbot @kyoto7250