cast_possible_truncation Suggest TryFrom when truncation possible
#10038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
xFrednet
force-pushed
the
9231-sugg-try-from
branch
2 times, most recently
from
dc887c5
to
cf5db9a
Compare
xFrednet
force-pushed
the
9231-sugg-try-from
branch
from
cf5db9a
to
9612b19
Compare
Jarcho
reviewed
Dec 8, 2022
xFrednet
force-pushed
the
9231-sugg-try-from
branch
from
9612b19
to
4a70f65
Compare
xFrednet
force-pushed
the
9231-sugg-try-from
branch
from
4a70f65
to
5cb6246
Compare
|
Good points! I've rebased, since it has been over a month. All changes are in the last commit, as well as a test for the Thank you for your patience, when it came to the update :) |
|
Thank you. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
I am a bit surprised that this was marked as closing #9231; at least I don't see a test for usize-to-u64 casts here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the last issues from #9664 as the author seems to be inactive. The PR author was sadly kept during the rebase, due to the conflict resolution.
IDK if it's worth it do to a full review, I only added the last commit, everything else remained the same, besides a rebase.
changelog: Sugg: [
cast_possible_truncation]: Now suggests usingtry_fromor allowing the lint#10038
closes: #9231