Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.58 MSRV for collapsible_str_replace #10047

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Dec 7, 2022

The Pattern impl for [char; N] was added in 1.58

changelog: Enhancement: [collapsible_str_replace]: Now takes MSRV into consideration. The minimal version is 1.58
#10047

@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2022

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 7, 2022
@xFrednet
Copy link
Member

xFrednet commented Dec 8, 2022

This looks excellent, thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 8, 2022

📌 Commit 591c18d has been approved by xFrednet

It is now in the queue for this repository.

@xFrednet
Copy link
Member

xFrednet commented Dec 8, 2022

@bors ping

@bors
Copy link
Collaborator

bors commented Dec 8, 2022

😪 I'm awake I'm awake

@xFrednet
Copy link
Member

xFrednet commented Dec 8, 2022

@bors r-

@xFrednet
Copy link
Member

xFrednet commented Dec 8, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 8, 2022

📌 Commit 591c18d has been approved by xFrednet

It is now in the queue for this repository.

@xFrednet
Copy link
Member

xFrednet commented Dec 8, 2022

It looks like bors is a bit sleepy today 😅

@xFrednet
Copy link
Member

xFrednet commented Dec 8, 2022

@bors r-

@xFrednet
Copy link
Member

xFrednet commented Dec 8, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 8, 2022

📌 Commit 591c18d has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 9, 2022

⌛ Testing commit 591c18d with merge 3492856...

@bors
Copy link
Collaborator

bors commented Dec 9, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 3492856 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Dec 9, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 3492856 to master...

@bors bors merged commit 3492856 into rust-lang:master Dec 9, 2022
@Alexendoo Alexendoo deleted the collapsible-str-replace-msrv branch December 9, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants